Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(app, sdks): adopt firebase-ios-sdk 11.8.0 / firebase-android-sdk 33.9.0 #8314

Merged
merged 4 commits into from
Feb 11, 2025
Merged

fix(app, sdks): adopt firebase-ios-sdk 11.8.0 / firebase-android-sdk 33.9.0 #8314

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
19367b8
fix: firebase-ios-sdk 11.8.0 / firebase-android-sdk 33.9.0
mikehardy Feb 10, 2025
96e385c
build(deps): bump all javascript packages except react-native
mikehardy Feb 10, 2025
d51539e
test(firestore, other): temporarily disable rollback test
mikehardy Feb 10, 2025
5a57845
test: adopt react-native 0.77.0 in e2e test app
mikehardy Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/scripts/functions/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@
},
"main": "lib/index.js",
"dependencies": {
"firebase-admin": "^13.0.2",
"firebase-admin": "^13.1.0",
"firebase-functions": "^6.3.1"
},
"devDependencies": {
"firebase-functions-test": "^3.4.0",
"firebase-tools": "^13.29.3",
"firebase-tools": "^13.30.0",
"typescript": "^5.7.3"
},
"private": true
Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/scripts/functions/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2310,9 +2310,9 @@ __metadata:
languageName: node
linkType: hard

"firebase-admin@npm:^13.0.2":
version: 13.0.2
resolution: "firebase-admin@npm:13.0.2"
"firebase-admin@npm:^13.1.0":
version: 13.1.0
resolution: "firebase-admin@npm:13.1.0"
dependencies:
"@fastify/busboy": "npm:^3.0.0"
"@firebase/database-compat": "npm:^2.0.0"
Expand All @@ -2331,7 +2331,7 @@ __metadata:
optional: true
"@google-cloud/storage":
optional: true
checksum: 10/152251443263af6f32aa03e18949aaa0f1fdd702bbe00d833346c455df59260df3994e905b925058050c0a57772ced303cdf1aa6c0ede9b3ce42d6f6eb0499cf
checksum: 10/703de42f0f26e1368b00bebc7d148fbc149e8b0444b9688b103c6bcdc723e15b86fc52716087f37d0da5e89d4ddb9ea10b91b1fe27b01a9a56f7c8dfe73d8714
languageName: node
linkType: hard

Expand Down Expand Up @@ -2367,9 +2367,9 @@ __metadata:
languageName: node
linkType: hard

"firebase-tools@npm:^13.29.3":
version: 13.29.3
resolution: "firebase-tools@npm:13.29.3"
"firebase-tools@npm:^13.30.0":
version: 13.30.0
resolution: "firebase-tools@npm:13.30.0"
dependencies:
"@electric-sql/pglite": "npm:^0.2.16"
"@google-cloud/cloud-sql-connector": "npm:^1.3.3"
Expand Down Expand Up @@ -2441,7 +2441,7 @@ __metadata:
yaml: "npm:^2.4.1"
bin:
firebase: lib/bin/firebase.js
checksum: 10/6da0c0a1eb7ebca0d94290b5ccaeac1be38a8862984ba78faca43bb4159d49ed1e5a11f2c07d7362f9363a2ebdf818cff4b6f9c6fd47280cfde3f7a36dc2e057
checksum: 10/5a33ad26843ed883de6ae1dc8f65de47938c2f21cb280eaf56c46fb225353d9a84c637d859c674d09d2afa3ea45665a36721d6864f6de10dd074165138ecea3f
languageName: node
linkType: hard

Expand Down Expand Up @@ -2575,10 +2575,10 @@ __metadata:
version: 0.0.0-use.local
resolution: "functions@workspace:."
dependencies:
firebase-admin: "npm:^13.0.2"
firebase-admin: "npm:^13.1.0"
firebase-functions: "npm:^6.3.1"
firebase-functions-test: "npm:^3.4.0"
firebase-tools: "npm:^13.29.3"
firebase-tools: "npm:^13.30.0"
typescript: "npm:^5.7.3"
languageName: unknown
linkType: soft
Expand Down
2 changes: 1 addition & 1 deletion docs/app-distribution/usage/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ Add the plugin to your `/android/build.gradle` file as a dependency:
buildscript {
dependencies {
// ...
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.1.0'
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.1.1'
}
```

Expand Down
2 changes: 1 addition & 1 deletion docs/crashlytics/android-setup.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ buildscript {
// ..
dependencies {
// ..
classpath 'com.google.firebase:firebase-crashlytics-gradle:3.0.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:3.0.3'
}
// ..
}
Expand Down
4 changes: 2 additions & 2 deletions docs/index.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,7 @@ project.ext {
// Overriding Library SDK Versions
firebase: [
// Override Firebase SDK Version
bom : "33.8.0"
bom : "33.9.0"
],
],
])
Expand All @@ -335,7 +335,7 @@ Open your projects `/ios/Podfile` and add any of the globals shown below to the

```ruby
# Override Firebase SDK Version
$FirebaseSDKVersion = '11.7.0'
$FirebaseSDKVersion = '11.8.0'
```

Once changed, reinstall your projects pods via pod install and rebuild your project with `npx react-native run-ios`.
Expand Down
18 changes: 9 additions & 9 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,39 +53,39 @@
"format:markdown": "prettier --write \"docs/**/*.md\""
},
"devDependencies": {
"@babel/core": "^7.26.7",
"@babel/core": "^7.26.8",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-private-methods": "^7.18.6",
"@babel/plugin-proposal-private-property-in-object": "^7.21.11",
"@babel/plugin-transform-class-properties": "^7.25.9",
"@babel/preset-env": "^7.26.7",
"@babel/preset-env": "^7.26.8",
"@eslint/eslintrc": "^3.2.0",
"@eslint/js": "^9.19.0",
"@eslint/js": "^9.20.0",
"@firebase/rules-unit-testing": "^4.0.1",
"@inquirer/prompts": "^7.3.1",
"@octokit/core": "^6.1.3",
"@tsconfig/node-lts": "^20.1.3",
"@types/react": "^18.3.18",
"@types/react-native": "^0.73.0",
"@typescript-eslint/eslint-plugin": "^8.23.0",
"@typescript-eslint/parser": "^8.23.0",
"@typescript-eslint/eslint-plugin": "^8.24.0",
"@typescript-eslint/parser": "^8.24.0",
"babel-jest": "^29.7.0",
"clang-format": "^1.8.0",
"conventional-changelog-cli": "^4.1.0",
"cross-env": "^7.0.3",
"eslint": "^9.19.0",
"eslint": "^9.20.0",
"eslint-config-prettier": "^10.0.1",
"eslint-plugin-mocha": "^10.5.0",
"eslint-plugin-prettier": "^5.2.3",
"eslint-plugin-react": "^7.37.4",
"firebase": "^11.2.0",
"firebase-tools": "^13.29.3",
"firebase": "^11.3.0",
"firebase-tools": "^13.30.0",
"genversion": "^3.2.0",
"google-java-format": "^1.4.0",
"jest": "^29.7.0",
"lerna": "^8.1.9",
"patch-package": "^8.0.0",
"prettier": "^3.4.2",
"prettier": "^3.5.0",
"regenerator-transform": "^0.15.2",
"rimraf": "^6.0.1",
"shelljs": "^0.8.5",
Expand Down
2 changes: 1 addition & 1 deletion packages/app-check/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"expo": ">=47.0.0"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-distribution/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"expo": ">=47.0.0"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
2 changes: 1 addition & 1 deletion packages/app-distribution/plugin/__tests__/__snapshots__/androidPlugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.1.0'
classpath 'com.google.firebase:firebase-appdistribution-gradle:5.1.1'
classpath("com.android.tools.build:gradle:4.1.0")

// NOTE: Do not place your application dependencies here; they belong
Expand Down
12 changes: 6 additions & 6 deletions packages/app/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,11 @@
"react-native": "*"
},
"dependencies": {
"firebase": "11.2.0"
"firebase": "11.3.0"
},
"devDependencies": {
"@react-native-async-storage/async-storage": "^2.1.1",
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand All @@ -73,7 +73,7 @@
},
"sdkVersions": {
"ios": {
"firebase": "11.7.0",
"firebase": "11.8.0",
"iosTarget": "13.0",
"macosTarget": "10.15",
"tvosTarget": "13.0"
Expand All @@ -82,12 +82,12 @@
"minSdk": 21,
"targetSdk": 34,
"compileSdk": 34,
"firebase": "33.8.0",
"firebaseCrashlyticsGradle": "3.0.2",
"firebase": "33.9.0",
"firebaseCrashlyticsGradle": "3.0.3",
"firebasePerfGradle": "1.4.2",
"gmsGoogleServicesGradle": "4.4.2",
"playServicesAuth": "21.3.0",
"firebaseAppDistributionGradle": "5.1.0"
"firebaseAppDistributionGradle": "5.1.1"
}
}
}
2 changes: 1 addition & 1 deletion packages/auth/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
},
"devDependencies": {
"@types/plist": "^3.0.5",
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
2 changes: 1 addition & 1 deletion packages/crashlytics/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"stacktrace-js": "^2.0.2"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
2 changes: 1 addition & 1 deletion packages/crashlytics/plugin/__tests__/__snapshots__/androidPlugin.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ buildscript {
jcenter()
}
dependencies {
classpath 'com.google.firebase:firebase-crashlytics-gradle:3.0.2'
classpath 'com.google.firebase:firebase-crashlytics-gradle:3.0.3'
classpath("com.android.tools.build:gradle:4.1.0")

// NOTE: Do not place your application dependencies here; they belong
Expand Down
2 changes: 1 addition & 1 deletion packages/dynamic-links/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
"expo": ">=47.0.0"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
10 changes: 10 additions & 0 deletions packages/firestore/e2e/Transaction.e2e.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,11 @@ describe('firestore.Transaction', function () {
});

it('should roll back any updates that failed', async function () {
// FIXME issue 8267
if (Platform.other) {
this.skip();
}

const docRef = firebase.firestore().doc(`${COLLECTION}/transactions/transaction/rollback`);

await docRef.set({
Expand Down Expand Up @@ -719,6 +724,11 @@ describe('firestore.Transaction', function () {
});

it('should roll back any updates that failed', async function () {
// FIXME issue 8267
if (Platform.other) {
this.skip();
}

const { getFirestore, runTransaction, doc, getDoc, setDoc } = firestoreModular;
const db = getFirestore();

Expand Down
2 changes: 1 addition & 1 deletion packages/messaging/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"expo": ">=47.0.0"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
2 changes: 1 addition & 1 deletion packages/perf/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
"expo": ">=47.0.0"
},
"devDependencies": {
"expo": "^52.0.30"
"expo": "^52.0.32"
},
"peerDependenciesMeta": {
"expo": {
Expand Down
4 changes: 2 additions & 2 deletions tests/android/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,9 @@ buildscript {
ext.compileSdkVersion = 35
ext.targetSdkVersion = 34

ext.ndkVersion = "26.1.10909125"
ext.ndkVersion = "27.1.12297006"

ext.kotlinVersion = '2.0.0' // https://kotlinlang.org/releases.html
ext.kotlinVersion = '2.0.21' // https://kotlinlang.org/releases.html
ext.supportLibVersion = '1.13.1' // this maps to androidx.core https://developer.android.com/jetpack/androidx/releases/core
ext.appCompatVersion = '1.7.0' // this maps to androidx.appcompat https://developer.android.com/jetpack/androidx/releases/appcompat
ext.supportVersion = ext.supportLibVersion
Expand Down
9 changes: 7 additions & 2 deletions tests/app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,16 @@
*/

import React from 'react';
import { StyleSheet, View, StatusBar, AppRegistry } from 'react-native';
import { StyleSheet, View, StatusBar, AppRegistry, LogBox } from 'react-native';

import { JetProvider, ConnectionText, StatusEmoji, StatusText } from 'jet';

// react-native-macos 0.77.0 - pops an empty, non-dismissable logbox
if (Platform.other) {
// ...unless you ignore all logs in logbox
LogBox.ignoreAllLogs();
}

const platformSupportedModules = [];

if (Platform.other) {
Expand Down Expand Up @@ -63,7 +69,6 @@ ErrorUtils.setGlobalHandler((err, isFatal) => {
throw err;
});

// eslint-disable-next-line @typescript-eslint/no-unused-vars
function loadTests(_) {
describe('React Native Firebase', function () {
if (!globalThis.RNFBDebug) {
Expand Down
Loading
Loading