Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: promises not executed sequentially #2

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: promises not executed sequentially #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ const args = require('yargs/yargs')(process.argv.slice(2))
describe: 'path to json params',
type: 'string'
}).demandOption(
['path'],
['path'],
'Please provide path argument to work with this tool'
).argv;

Expand Down Expand Up @@ -67,7 +67,7 @@ const filterObject = (names, stages, obj) => {
returnArray = returnArray.concat(y[key]);
}
}
});
});
return returnArray;
} else {
//filter the stages
Expand All @@ -82,16 +82,18 @@ const filterObject = (names, stages, obj) => {
});
return returnArray;
}

}

async function doAllSequentually(arrFnPromiseList) {
if(!arrFnPromiseList || !Array.isArray(arrFnPromiseList) || !arrFnPromiseList.length) {
if(!arrFnPromiseList || !Array.isArray(arrFnPromiseList) || !arrFnPromiseList.length) {
spinner.fail();
console.error('Promise list doesnt exist or isnt an array. please check your json config file and ensure it is valid')
return;
}
arrFnPromiseList.forEach(async (x)=> {await x.promise();});
for (const x of arrFnPromiseList) {
await x.promise();
}
}

doAllSequentually(prepDeploy(args.name, args.stage, args.path))
Expand Down