[IMP] hr_attendance_missing_days: don't break on multi work day attendances #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hbrunn
commented
Dec 23, 2023
| @@ -79,6 +79,9 @@ def _create_missing_attendances(self, date_from=None, date_to=None): | |||
| attendances = { | |||
| ensure_tz(attendance.check_in, tz).date() | |||
| for attendance in self.attendance_ids.filtered_domain(domain) | |||
| } | { | |||
| ensure_tz(attendance.check_out, tz).date() | |||
| for attendance in self.attendance_ids.filtered_domain(domain) | |||
There was a problem hiding this comment.
I considered enumerating the days between check_in and check_out, but then I couldn't think of a real live case where anyone records 24+ hours
There was a problem hiding this comment.
Technically it's clean but the entire self.attendance_ids.filtered_domain(domain) would be executed multiple times. I guess the following could be better (well I'm not fully pleased with the naming)
attendances = self.attendance_ids.filtered_domain(domain)
attendances = attendances.mapped("check_in") + attendances.mapped("check_out")
attendances = {ensure_tz(attendance, tz).date() for attendance in attendances}
fkantelberg
requested changes
Dec 27, 2023
| @@ -79,6 +79,9 @@ def _create_missing_attendances(self, date_from=None, date_to=None): | |||
| attendances = { | |||
| ensure_tz(attendance.check_in, tz).date() | |||
| for attendance in self.attendance_ids.filtered_domain(domain) | |||
| } | { | |||
| ensure_tz(attendance.check_out, tz).date() | |||
| for attendance in self.attendance_ids.filtered_domain(domain) | |||
There was a problem hiding this comment.
Technically it's clean but the entire self.attendance_ids.filtered_domain(domain) would be executed multiple times. I guess the following could be better (well I'm not fully pleased with the naming)
attendances = self.attendance_ids.filtered_domain(domain)
attendances = attendances.mapped("check_in") + attendances.mapped("check_out")
attendances = {ensure_tz(attendance, tz).date() for attendance in attendances}
fkantelberg
merged commit 532f10f
into
initOS:15.0-hr_attendance_missing_days
3 of 4 checks passed
fkantelberg
pushed a commit
that referenced
this pull request
Jan 15, 2024
…dances (#1) * [IMP] hr_attendance_missing_days: don't break on multi work day attendances * [ADD] hr_attendance_contract_missing_days: tests * fixup! [ADD] hr_attendance_contract_missing_days: tests
ortlam
pushed a commit
that referenced
this pull request
May 28, 2024
…dances (#1) * [IMP] hr_attendance_missing_days: don't break on multi work day attendances * [ADD] hr_attendance_contract_missing_days: tests * fixup! [ADD] hr_attendance_contract_missing_days: tests
ortlam
pushed a commit
that referenced
this pull request
Aug 14, 2024
…dances (#1) * [IMP] hr_attendance_missing_days: don't break on multi work day attendances * [ADD] hr_attendance_contract_missing_days: tests * fixup! [ADD] hr_attendance_contract_missing_days: tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@fkantelberg thanks again for this. We ran into an issue when an attendance spans multiple days in the work calendar, here my proposed fix plus test case.
While being on it, I took the liberty to add another commit adding a test for
hr_attendance_contract_missing_days, hoping greenness will trigger the good people of hr-attendance maintainers to merge the PR.