Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use external PNG crate. #418

Merged
merged 3 commits into from
Jun 8, 2015
Merged

Use external PNG crate. #418

merged 3 commits into from
Jun 8, 2015

Conversation

nwin
Copy link
Contributor

@nwin nwin commented May 26, 2015

Image::png is now just a little layer over an external codec crate.

Closes #390 #300 #400 #414

@nwin
Copy link
Contributor Author

nwin commented May 26, 2015

Note this is WIP. I will move the png crate to PistonDevelopers before merging.

@tomaka
Copy link
Contributor

tomaka commented May 26, 2015

:(

According to one of the Servo devs (don't remember who exactly), using C code defeats the purpose of using image in the first place.

@nwin
Copy link
Contributor Author

nwin commented May 26, 2015

Servo already depends on flate2. At least @kmcallister seemed to be fine with it.

@bvssvni
Copy link
Contributor

bvssvni commented May 26, 2015

@nwin You are awesome!

@bvssvni bvssvni mentioned this pull request May 26, 2015
@bvssvni
Copy link
Contributor

bvssvni commented May 26, 2015

@tomaka I opened #419

@LaylBongers
Copy link

Having a pure rust implementation for most things would be preferable in my opinion.

Edit for more explanation: It wouldn't be an "Imaging library written in Rust" anymore. That it's in Rust and not something else should in my opinion be considered an important feature. For some platforms, dependency management to C isn't that easy. Especially on Windows, C libraries tend to cause nightmares. Next to that, replacing the Rust implementation with a binding to a C one removes the benefit Rust gives with the safety guarantees.

Edit 2: It seems I partly misunderstood what this is doing and what's bringing the C code in play. My bad for not doing proper research before commenting. Still, my problem with it stands that a C dependency would cause more problems than it's worth.

@bvssvni
Copy link
Contributor

bvssvni commented May 27, 2015

@LaylConway See #419

nwin added 3 commits June 7, 2015 19:17
Image::png is now just a little layer over an external codec crate.
@nwin
Copy link
Contributor Author

nwin commented Jun 8, 2015

So the updated PNG crate now uses flate2 only for encoding.

nwin added a commit that referenced this pull request Jun 8, 2015
@nwin nwin merged commit 720dcc9 into image-rs:master Jun 8, 2015
fintelia pushed a commit that referenced this pull request Dec 20, 2024
fintelia pushed a commit that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add compression to PNG
4 participants