Implement basic functionality for virtualization #690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
jadamita
reviewed
Jan 22, 2025
| ...(rowStyle ? rowStyle(record, virtualRow.index) : {}), | ||
| height: `${virtualRow.size}px`, | ||
|
|
||
| // transform: `translateY(${virtualRow.start}px)`, |
There was a problem hiding this comment.
I'd probably remove the commented code that was left in.
|
You also want to target your PR against the next branch. This is outlined here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @icflorescu !
Recently the need for a virtualization increased on my side. I tried to implement the virtualization with TanStack's virtual table example.
So far the base implementation (measuring elements, overscanning, remounting DOM elements, ...) works.
What is left:
I hope you or someone else can support with the relative visual todos so that we can all benefit from the feature.