Css improvements 2022: combinators, attribute-selectors, and :checked #809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ArneBab
commented
Dec 10, 2022
•
ArneBab
commented
- Support CSS combinators, i.e. a ~ b
- support more attribute selectors
- support :checked
ArneBab
force-pushed
the
css-improvements-2022
branch
2 times, most recently
from
179e0cd to
135a9e0
Compare
ArneBab
changed the title
|
Added tests and fixed a bug that caused only the first char of the key in a[foo$=bar] to be checked, so $= was accepted — falsely. Found that bug because the test succeeded even after I removed the changes — unexpected success pointed to a bug ☺ Also simplified the implementation for ~, because > and + were already supported, I just hadn’t spotted that. Found while adding the test. |
ArneBab
force-pushed
the
css-improvements-2022
branch
from
e96b018 to
20e056b
Compare
Bombe
reviewed
Sep 6, 2023
Bombe
reviewed
Sep 6, 2023
ArneBab
force-pushed
the
css-improvements-2022
branch
from
6dff862 to
bc3a20d
Compare
Bombe
reviewed
Sep 11, 2023
Bombe
reviewed
Oct 5, 2023
It changed more than needed.
ArneBab
force-pushed
the
css-improvements-2022
branch
from
839599b to
4e18c49
Compare
|
@Bombe I fixed the merge conflicts and force pushed the result — is this good to go? |
Bombe
approved these changes
Jan 31, 2024
|
Merged — thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.