Trivuele batch 1 reviewed v2 #773
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
May 18, 2022 08:43
Let us encourage users to increase the size of their datastore if it is below 10% of available free disk space, which is clearly below the 40% of available free disk space we suggest in the wizard. The wizard suggested very small sizes before, so the network can benefit if we get nodes to upgrade their datastore sizes. It is also possible that people have bought new larger disks and just moved their Freenet installation. If a user has chosen a very small size during the first time wizard, this user alert also acts as a way for them to change their mind. The user alert will send you to the wizard step again to reconfigure, but will not change datastore type, just size. The user alert is at warning level, and can be dismissed.
Both the gradle distribution and all .jar dependencies can be put in the lib directory. They can be downloaded from Freenet or from Tor ahead of time, and the file integrity will still be validated using the commited checksums. I could not figure out how to get the android dependency to work in offline mode, so let us disable it until someone does. It is not needed when building for desktop.
The datastore is only effective at low HTL since all requests for a block is routed towards a certain location. At high HTL we would at best overwrite some low HTL data block with data block that is never going to be requested from us, at worst we reveal that we or a nearby node have requested this data block since it otherwise would be highly unlikely for us to have it. This feature is a security issue, while providing no meaningful performance gain in theory. The only reason why you would want to enable this feature is if you are bootstrapping a very small darknet, since otherise no node would write anything to their datastores. For nodes running opennet, force disable this option to avoid leaving users with it enabled. For nodes running darknet, it would already have been disabled by the security levels, so leave the value as it is.
|
Closed in favor of #777 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are what I see as obviously good from the code side (need testing, though).