Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: updating DIDComm protocols closer to specification #373

Merged
merged 1 commit into from
Feb 12, 2025
Merged

feat!: updating DIDComm protocols closer to specification #373

merged 1 commit into from
Feb 12, 2025

Conversation

curtis-h
Copy link
Contributor

@curtis-h curtis-h commented Feb 5, 2025 •
edited
Loading

Description:

#359

Updating didcomm protocols to be closer to specification.
Tidying up some types and helper functions.

BREAKING CHANGES:

  • IssueCredential.build removed
  • IssueCredential.makeIssueFromRequestCredential removed
  • OfferCredential.build removed
  • OfferCredential.makeOfferFromProposedCredential removed

Checklist:

  • My PR follows the contribution guidelines of this project
  • My PR is free of third-party dependencies that don't comply with the Allowlist
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked the PR title to follow the conventional commit specification

@curtis-h curtis-h self-assigned this Feb 5, 2025
@curtis-h curtis-h force-pushed the feature/359-didcomm-protocols branch from 8b96a9b to 11467a5 Compare February 10, 2025 10:36
@curtis-h curtis-h marked this pull request as ready for review February 10, 2025 10:37
@curtis-h curtis-h requested a review from a team as a code owner February 10, 2025 10:37
@github-actions GitHub Actions
Copy link

Lines Statements Branches Functions
Coverage: 77%
 78.04% (3707/4750) 68.36% (1727/2526) 81.95% (881/1075)

@coveralls
Copy link

Coverage Status

coverage: 74.483% (-0.03%) from 74.511%
when pulling 11467a5 on feature/359-didcomm-protocols
into 99bea3f on main.

yshyn-iohk
yshyn-iohk approved these changes Feb 11, 2025
View reviewed changes
Copy link
Contributor

@yshyn-iohk yshyn-iohk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@elribonazo
Copy link
Contributor

@curtis-h please remember breaking changes in here, it is a minor one but a BK

@curtis-h curtis-h force-pushed the feature/359-didcomm-protocols branch from 11467a5 to 9e18487 Compare February 12, 2025 13:28
@curtis-h curtis-h changed the title feat: updating DIDComm protocols closer to specification feat!: updating DIDComm protocols closer to specification Feb 12, 2025
@curtis-h curtis-h force-pushed the feature/359-didcomm-protocols branch from 9e18487 to 8541e1e Compare February 12, 2025 14:05
@curtis-h curtis-h merged commit 9f85fac into main Feb 12, 2025
6 checks passed
@curtis-h curtis-h deleted the feature/359-didcomm-protocols branch February 12, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elribonazo elribonazo elribonazo approved these changes

@yshyn-iohk yshyn-iohk yshyn-iohk approved these changes

Assignees

@curtis-h curtis-h

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@curtis-h @coveralls @elribonazo @yshyn-iohk