Update for suggestions

huoyaoyuan · Dec 2, 2024 · 7ece8ec · 7ece8ec
1 parent 68f4fa5
commit 7ece8ec
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/osu.Game/Overlays/ChatOverlay.cs b/osu.Game/Overlays/ChatOverlay.cs
@@ -386,9 +386,8 @@ private void joinedChannelsChanged(object? sender, NotifyCollectionChangedEventA
                     {
                         channelList.RemoveChannel(channel);
 
-                        if (loadedChannels.TryGetValue(channel, out var loaded))
+                        if (loadedChannels.Remove(channel, out var loaded))
                         {
-                            loadedChannels.Remove(channel);
                             // DrawableChannel removed from cache must be manually disposed
                             loaded.Dispose();
                         }

diff --git a/osu.Game/Rulesets/Mods/ModAdaptiveSpeed.cs b/osu.Game/Rulesets/Mods/ModAdaptiveSpeed.cs
@@ -173,10 +173,10 @@ public void ApplyToDrawableHitObject(DrawableHitObject drawable)
             };
             drawable.OnRevertResult += (_, result) =>
             {
-                if (!ratesForRewinding.TryGetValue(result.HitObject, out double rewindValue)) return;
+                if (!ratesForRewinding.TryGetValue(result.HitObject, out double rate)) return;
                 if (!shouldProcessResult(result)) return;
 
-                recentRates.Insert(0, rewindValue);
+                recentRates.Insert(0, rate);
                 ratesForRewinding.Remove(result.HitObject);
 
                 recentRates.RemoveAt(recentRates.Count - 1);