Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#50): add --no-validate #496

Merged
merged 13 commits into from
Dec 19, 2024
Merged

fix(#50): add --no-validate #496

merged 13 commits into from
Dec 19, 2024

Conversation

KyleKing
Copy link
Contributor

@KyleKing KyleKing commented Dec 17, 2024 •
edited
Loading

Add --no-validate CLI option and corresponding validate = True configuration

This configuration will help users debug issues by running mdformat in a breaking fashion and allowing manual review of the changes that mdformat identified as breaking

Fixes: #50

hukkin
hukkin reviewed Dec 18, 2024
View reviewed changes
@KyleKing KyleKing marked this pull request as ready for review December 18, 2024 12:18
KyleKing
KyleKing commented Dec 18, 2024
View reviewed changes
Copy link
Contributor Author

@KyleKing KyleKing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the coverage CI failures, I think this PR is ready for review!

hukkin
hukkin requested changes Dec 18, 2024
View reviewed changes
@KyleKing KyleKing requested a review from hukkin December 19, 2024 00:50
hukkin
hukkin requested changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@hukkin hukkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two minor nits, otherwise LGTM!

@codecov Codecov
Copy link

codecov bot commented Dec 19, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (52f3c06) to head (c19203f).
Report is 20 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master      #496   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           15        15           
  Lines          947       951    +4     
  Branches       166       168    +2     
=========================================
+ Hits           947       951    +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@KyleKing KyleKing requested a review from hukkin December 19, 2024 10:37
@hukkin hukkin merged commit 062ad6d into hukkin:master Dec 19, 2024
24 checks passed
@hukkin
Copy link
Owner

hukkin commented Dec 19, 2024

Thanks!

@KyleKing KyleKing deleted the fix-50--no-validate branch December 19, 2024 11:22
@hukkin hukkin mentioned this pull request Dec 19, 2024
Closed
@KyleKing KyleKing mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hukkin hukkin Awaiting requested review from hukkin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add --fast flag to skip Markdown validation
2 participants
@KyleKing @hukkin