Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chicken flickering / teleporting around #18203

Closed
5 tasks done
justafella opened this issue Sep 23, 2023 · 17 comments
Closed
5 tasks done

Chicken flickering / teleporting around #18203

justafella opened this issue Sep 23, 2023 · 17 comments
Milestone

Comments

@justafella
Copy link

justafella commented Sep 23, 2023

Game or games this happens in

ULUS-10458 - Harvest Moon: Hero of Leaf Valley

What area of the game / PPSSPP

Inside the chicken coop, whenever chicks or chickens move.

What should happen

No flicker in movement. It's been a long time since I last used PPSSPP, but this is definitely a bug. It never happenend at least until version 1.13. I'll try to pin down the last working version later on my pc. I made a sreenrecord of the issue.
https://drive.google.com/file/d/12XSn86QQJJdnJk4oNjCat1oqwY8X_NiH/view?usp=drivesdk

Logs

No response

Platform

Android

Mobile phone model or graphics card

Xiaomi Redmi 9 (M2004J19C)

PPSSPP version affected

1.16.3

Last working version

1.13

Graphics backend (3D API)

Vulkan

Checklist

  • Test in the latest git build in case it's already fixed.
  • Search for other reports of the same issue.
  • Try resetting settings or older versions and include if the issue is related.
  • Try without any cheats and without loading any save states.
  • Include logs or screenshots of issue.
@hrydgard
Copy link
Owner

hrydgard commented Sep 23, 2023

This looks like a CPU emulation bug, fairly unlikely to be anything else, although could be some edge case wacky transform matrix reload behavior in the GPU emulation I suppose... Could also be a cache issue where the game accidentally misuses the cpu data cache.

Does it make a difference if you, as CPU Core in Settings/Tools/Developer Settings, pick the Interpreter or IR Interpreter, or even IR JIt options?

@hrydgard hrydgard added this to the v1.17.0 milestone Sep 23, 2023
@hrydgard hrydgard changed the title Chicken flickering Chicken flickering. Sep 23, 2023
@hrydgard hrydgard changed the title Chicken flickering. Chicken flickering / teleporting around Sep 23, 2023
@justafella
Copy link
Author

justafella commented Sep 23, 2023 via email

@hrydgard
Copy link
Owner

hrydgard commented Sep 23, 2023

Okay, that is very interesting then!

One more thing you can play with - in Developer Tools, we also have "Jit Debug tools", where you can turn off parts of the JIT by checking boxes. So, if you have the time, switch back to JIT, and then see if any particular box there fixes it when it alone is checked. Likely an FPU or VFPU one...

Also, a savestate nearby would be cool. Just zip and upload to a post here.

@justafella
Copy link
Author

justafella commented Sep 23, 2023 via email

@hrydgard
Copy link
Owner

Huh, that is .. even more surprising! Something really odd going on here.. Thank you for testing.

@unknownbrackets
Copy link
Collaborator

It would be interesting if this wasn't a problem in the IR-based jits.

-[Unknown]

@justafella
Copy link
Author

justafella commented Sep 24, 2023 via email

@hrydgard
Copy link
Owner

That's good to confirm it's not something recent. Thanks for testing!

@justafella
Copy link
Author

Just now I realized you asked for a save state. I did one. There are 2 chickens outside with normal behavior, and 1 inside the chicken coop, where it bugs. I haven't tried to bring one of them inside other places, but I remember, while taking part-time job for Ronald, that his chickens bug inside his coop too.
PPSSPP_STATE.zip

@justafella
Copy link
Author

Forgot to mention that Windows versions have no issues

@justafella
Copy link
Author

justafella commented Sep 27, 2023

I have another report. This time I will not open a new topic because I think It is the same problem. This time, at Horse Races, horses teleport over the fence, out of the track and get stuck there. Changing CPU Core to any Interpreter fixes it at cost of FPS. I have a screenrecord and a save state at the event. I am currently at Summer's Horse Races, but it happened at Spring's too. The game runs at 15 FPS on races, but I think it is by design since it has a timer that counts seconds normally.

Link to video https://drive.google.com/file/d/13HEAtyTAcSsUX2Wz17dZ-pZulr2z4t7o/view?usp=drivesdk

Save state
PPSSPP_STATE.zip

@unknownbrackets
Copy link
Collaborator

unknownbrackets commented Sep 27, 2023

The chicken thing does not seem to occur with the new IR based jit (#18229), the chicken seemed to move naturally. Performance was about the same as jit on my device (where the bug does occur.)

-[Unknown]

@justafella
Copy link
Author

justafella commented Sep 27, 2023 via email

@unknownbrackets
Copy link
Collaborator

Sorry for saying it in a confusing way. There's a new experimental jit that you can't use yet in any stable version. It doesn't have this bug. I still see the bug in the latest stable versions with the "old" (current) jit. #18249 should fix that.

I didn't check the horse but it's probably the same issue.

-[Unknown]

@justafella
Copy link
Author

justafella commented Sep 27, 2023 via email

@justafella
Copy link
Author

Everything worked perfectly fine on the latest build. I tested horse races multiple times and it runs just perfect. Chickens inside the coop are behaving perfectly normal too. Everything fixed! Thank you so much!

@hrydgard
Copy link
Owner

thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants