Return with false, if there are no results #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hnsl
reviewed
Sep 25, 2016
| @@ -103,8 +109,10 @@ create or replace function colpivot( | |||
| foreach col in array key_cols loop | |||
| if i > 0 then | |||
| on_e := on_e || ' and '; | |||
| on_e := on_e || '(' || ali || '.' || quote_ident(col) || ' = _key.' || quote_ident(col) || ' OR (' || ali || '.' || quote_ident(col) || ' IS NULL AND _key.' || quote_ident(col) || ' IS NULL)) '; | |||
| else | |||
| on_e := on_e || ali || '.' || quote_ident(col) || ' = _key.' || quote_ident(col) || ' '; | |||
There was a problem hiding this comment.
Why does the first column not get the null comparison check? It's probably obvious but it was so long that I wrote this code.
There was a problem hiding this comment.
Beats me. I would have to test the function with and without checking for null. I'm also in the "fire and forget" mode 😆 But as I use it in the production, I guess it works regardless of maybe useless bloat.
I will check it out, if I have time for it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.