Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test assertions to match new procfile output #908

Merged
merged 2 commits into from
Feb 4, 2025
Merged

Update test assertions to match new procfile output #908

merged 2 commits into from
Feb 4, 2025

Conversation

joshwlewis
Copy link
Member

@joshwlewis joshwlewis commented Feb 4, 2025 •
edited
Loading

Newer versions of the procfile buildpack have different output, so CI tests are failing. This fixes the tests.

@joshwlewis joshwlewis marked this pull request as ready for review February 4, 2025 21:39
@joshwlewis joshwlewis requested a review from a team as a code owner February 4, 2025 21:39
@joshwlewis joshwlewis mentioned this pull request Feb 4, 2025
Merged
edmorley
edmorley approved these changes Feb 4, 2025
View reviewed changes
Copy link
Member

@edmorley edmorley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@joshwlewis joshwlewis merged commit 9821134 into main Feb 4, 2025
5 of 6 checks passed
@joshwlewis joshwlewis deleted the jwl/test-update branch February 4, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edmorley edmorley edmorley approved these changes

Assignees
No one assigned
Labels
libcnb-test skip changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joshwlewis @edmorley