Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS resolver should not be possible to set per request - 2.x #4815

Merged
merged 1 commit into from
Aug 31, 2022
Merged

DNS resolver should not be possible to set per request - 2.x #4815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions webclient/webclient/src/main/java/io/helidon/webclient/WebClientRequestBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,14 +319,6 @@ default WebClientRequestBuilder addHeaders(Parameters parameters){
*/
WebClientRequestBuilder allowChunkedEncoding(boolean allowChunkedEncoding);

/**
* Set which type of DNS resolver should be used.
*
* @param dnsResolverType type of the DNS resolver to be used
* @return updated builder instance
*/
WebClientRequestBuilder dnsResolverType(DnsResolverType dnsResolverType);

/**
* Performs prepared request and transforms response to requested type.
*
Expand Down
6 changes: 0 additions & 6 deletions webclient/webclient/src/main/java/io/helidon/webclient/WebClientRequestBuilderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -400,12 +400,6 @@ public WebClientRequestBuilder allowChunkedEncoding(boolean allowChunkedEncoding
return this;
}

@Override
public WebClientRequestBuilder dnsResolverType(DnsResolverType dnsResolverType) {
this.dnsResolverType = dnsResolverType;
return this;
}

@Override
public <T> Single<T> request(Class<T> responseType) {
return request(GenericType.create(responseType));
Expand Down