Implement setupTLSConfig using consul/api #3281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-wenmouth
force-pushed
the
bugfix/3248
branch
from
1069c9a to
2b8e295
Compare
Update function `setupTLSConfig` to use the `consul/api` function `SetupTLSConfig`. Fixes issue where client certificates were not loaded which then caused mutual TLS to fail unexpectedly.
simon-wenmouth
force-pushed
the
bugfix/3248
branch
from
2b8e295 to
6cc9b41
Compare
|
This change causes the issue to be resolved when the CONSUL_* environment variables are present. I'm going to close this PR until such a time as that those environment variables are optional. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update function
setupTLSConfigto use theconsul/apifunctionSetupTLSConfig. Fixes issue where client certificates were not loaded (nil) which then caused mutual TLS to fail unexpectedly.See: #3248