Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add authoritative IAM policy binding for KMS Crypto Keys #4164

Closed
wants to merge 3 commits into from
Closed

Add authoritative IAM policy binding for KMS Crypto Keys #4164

wants to merge 3 commits into from

Conversation

maroux
Copy link
Contributor

@maroux maroux commented Aug 5, 2019

Fixes #4163

@danawillow danawillow self-requested a review December 17, 2019 00:05
@danawillow
Copy link
Contributor

Hey @maroux, sorry for the delay! You still interested in getting this merged? If so, would you mind resolving merge conflicts?

@maroux
Copy link
Contributor Author

maroux commented Dec 18, 2019

@danawillow updated.

@ghost ghost removed the waiting-response label Dec 18, 2019
danawillow
danawillow suggested changes Dec 18, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, just a few small things

google/resource_kms_crypto_key_iam_test.go Outdated Show resolved Hide resolved
website/docs/r/google_kms_crypto_key_iam.html.markdown Show resolved Hide resolved
website/docs/r/google_kms_crypto_key_iam.html.markdown Outdated Show resolved Hide resolved
danawillow
danawillow approved these changes Dec 19, 2019
View reviewed changes
Copy link
Contributor

@danawillow danawillow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! I'll get this upstreamed into https://github.com/GoogleCloudPlatform/magic-modules.

@danawillow danawillow mentioned this pull request Dec 20, 2019
Merged
@danawillow
Copy link
Contributor

I ended up having to make some small changes to this so I merged the downstream from MM (#5247) instead. You still get commit credit in MM though :)

@danawillow danawillow closed this Dec 23, 2019
@ghost
Copy link

ghost commented Jan 23, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jan 23, 2020
@maroux maroux deleted the 4163 branch February 11, 2020 15:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danawillow danawillow danawillow approved these changes

Assignees
No one assigned
Labels
documentation size/xl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for google_kms_crypto_key_iam_policy
2 participants
@maroux @danawillow