Terraform: Skip diffs when managed certs are specified with absolute …

…FQDNs Signed-off-by: Modular Magician <[email protected]>
hashicorp · Apr 5, 2019 · 75ca941 · 75ca941
1 parent f5bcdd3
commit 75ca941
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/google-beta/resource_compute_managed_ssl_certificate.go b/google-beta/resource_compute_managed_ssl_certificate.go
@@ -19,6 +19,7 @@ import (
 	"log"
 	"reflect"
 	"strconv"
+	"strings"
 	"time"
 
 	"github.com/hashicorp/terraform/helper/schema"
@@ -58,6 +59,12 @@ func resourceComputeManagedSslCertificate() *schema.Resource {
 							Type:     schema.TypeList,
 							Required: true,
 							ForceNew: true,
+							DiffSuppressFunc: func(k, old, new string, _ *schema.ResourceData) bool {
+								if k == "managed.0.domains.0" {
+									return old == strings.TrimRight(new, ".")
+								}
+								return old == new
+							},
 							MaxItems: 1,
 							Elem: &schema.Schema{
 								Type: schema.TypeString,

diff --git a/google-beta/resource_compute_managed_ssl_certificate_generated_test.go b/google-beta/resource_compute_managed_ssl_certificate_generated_test.go
@@ -51,7 +51,7 @@ resource "google_compute_managed_ssl_certificate" "default" {
   name = "test-cert-%{random_suffix}"
 
   managed {
-    domains = ["sslcert.tf-test.club"]
+    domains = ["sslcert.tf-test.club."]
   }
 }
 

diff --git a/website/docs/r/compute_managed_ssl_certificate.html.markdown b/website/docs/r/compute_managed_ssl_certificate.html.markdown
@@ -65,7 +65,7 @@ resource "google_compute_managed_ssl_certificate" "default" {
   name = "test-cert"
 
   managed {
-    domains = ["sslcert.tf-test.club"]
+    domains = ["sslcert.tf-test.club."]
   }
 }