Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the compute service api-version from 2019-07-01 to 2019-12-01 #7101

Merged
merged 11 commits into from
Jun 18, 2020
Prev Previous commit
Update orchestrated_virtual_machine_scale_set_resource.go
  • Loading branch information
katbyte authored Jun 18, 2020
commit 6059aa6e22686c03248787eeb29fb843e74b1f50
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ func resourceArmOrchestratedVirtualMachineScaleSet() *schema.Resource {
Optional: true,
ForceNew: true,
Default: false,
Deprecated: "this property has been deprecated starting from api-version 2019-12-01 and will be removed in version 3.0 of the provider",
Deprecated: "Due to an upgrade of the compute API this preview property has now been deprecated and required to be false in the 2019-12-01 api versions for orchestrated VMSS - as it will always be false for the current and future API versions this property now defaults to false and will removed in version 3.0 of the provider.",
ValidateFunc: validateBoolIsFalse,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a breaking change - previously this could be set to true?

Copy link
Contributor

@fitzgeraldsteele fitzgeraldsteele Jun 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Tom, I'm the Microsoft PM behind this feature, working with @ArcturusZhang to expose to Terraform. I can confirm that for this preview feature, we changed from true to false to support an update of the technology stack. We don't have any customers using spg=true for this preview at the moment, but we do have customers waiting for spg=false.

Would it be ok to allow this value to be true or false, and just pass the value to Azure to do the validation? Happy to discuss or talk through whatever needed so that we can get this out ASAP

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fitzgeraldsteele - right now the property is forced to be true in terraform so anyone using the resource would have spg=true, and to date the previous API version still works with spg=true - are you saying absolutely no one is currently using orchestrated VMSSs via terraform at this time?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(its been released so anyone could be using it atm)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the usage data now. We are closing/discontinuing the preview that uses spg=true, and are working to unblock customers using spg=false. Our documentation will have this update. If we document that in the changelog here, can we bring this back into the 2.14 release?

Happy to have a non-github discussion...I don't want to post the usage data here. :) jerry steele @ microsoft

},

Expand Down