-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azurerm_mssql_managed_instance_failover_group
: add property secondary_type
#28633
Conversation
website/docs/r/mssql_managed_instance_failover_group.html.markdown
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @wyattfry, I've left a few comments inline if you wouldn't mind reviewing those!
internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource.go
Outdated
Show resolved
Hide resolved
internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource.go
Outdated
Show resolved
Hide resolved
internal/services/mssqlmanagedinstance/mssql_managed_instance_failover_group_resource_test.go
Outdated
Show resolved
Hide resolved
website/docs/r/mssql_managed_instance_failover_group.html.markdown
Outdated
Show resolved
Hide resolved
…failover_group_resource.go Co-authored-by: sreallymatt <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Provided the tests are still passing after these changes, LGTM
…r-azurerm into wyatt/mssql-managed-instance-secondary-type
doing one last test run with the latest master |
Community Note
Description
azurerm_mssql_managed_instance_failover_group
: add propertysecondary_type
, possible values areGeo
andStandby
PR Checklist
For example: “
resource_name_here
- description of change e.g. adding propertynew_property_name_here
”Changes to existing Resource / Data Source
Testing
Change Log
Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.
azurerm_mssql_managed_instance_failover_group
: add propertysecondary_type
[azurerm_mssql_managed_instance_failover_group
: add propertysecondary_type
#28633]This is a (please select all that apply):
Related Issue(s)
Fixes #26104
Note
If this PR changes meaningfully during the course of review please update the title and description as required.