azurerm_postgresql_server - deprecate ssl_enforcement_enabled and ssl_minimal_tls_version_enforced no longer accpets TLSEnforcementDisabled, TLS1_0 or TLS1_1 as a value in 5.0

[ziyeqf]

Community Note

• Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
• Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

As the announcement, update the documents and deprecate tls 1.0 and tls 1.1 in v5.0

Also, deprecate ssl_enforcement_enabled in 5.0 since it will always be true when ssl_minimal_tls_version_enforced is set to 1.2

PR Checklist

• I have followed the guidelines in our Contributing Documentation.
• I have checked to ensure there aren't other open Pull Requests for the same update/change.
• I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
• I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
• I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
  For example: “resource_name_here - description of change e.g. adding property new_property_name_here”

Changes to existing Resource / Data Source

• I have added an explanation of what my changes do and why I'd like you to include them (This may be covered by linking to an issue above, but may benefit from additional explanation).
• I have written new tests for my resource or datasource changes & updated any relevent documentation.
• I have successfully run tests with my changes locally. If not, please provide details on testing challenges that prevented you running the tests.
• (For changes that include a state migration only). I have manually tested the migration path between relevant versions of the provider.

Testing

• My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

4.0

5.0

Change Log

Below please provide what should go into the changelog (if anything) conforming to the Changelog Format documented here.

• azurerm_postgresql_server - deprecate ssl_enforcement_enabled and ssl_minimal_tls_version_enforced no longer accpets TLSEnforcementDisabled, TLS1_0 or TLS1_1 as a value in 5.0 [azurerm_postgresql_server - deprecate ssl_enforcement_enabled and ssl_minimal_tls_version_enforced no longer accpets TLSEnforcementDisabled, TLS1_0 or TLS1_1 as a value in 5.0 #28247]

This is a (please select all that apply):

• Bug Fix
• New Feature (ie adding a service, resource, or data source)
• Enhancement
• Breaking Change

Related Issue(s)

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

[stephybun]

Suggested change

	Deprecated: "The `ssl_enforcement_enabled` is deprecated as Azure services will require TLS1.2+ to connect.",
	Deprecated: "The `ssl_enforcement_enabled` property is deprecated as Azure services will require TLS1.2+ to connect.",

[stephybun]

This probably wants to become Optional so users can begin removing it from their configs

Suggested change

	Required: true,
	Optional: true,

[stephybun]

Since this property is deprecated, I think it's acceptable to have one test or template that still includes it (to check that it still works) but to remove it from all other test configurations.

Since we have it in the template I'd suggest removing it from this and all other test configurations below

Suggested change

	sslEnabledBlock := ``
	if !features.FivePointOhBeta() {
	sslEnabledBlock = `ssl_enforcement_enabled = true`
	}