Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Resource: azurerm_arc_machine_automanage_configuration_assignment #26657

Merged
merged 16 commits into from
Sep 13, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/labeler-issue-triage.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ service/authorization:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(client_config|federated_identity_credential|marketplace_role_assignment|pim_|role_|user_assigned_identity)((.|\n)*)###'

service/automanage:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(automanage_configuration|virtual_machine_automanage_configuration_assignment)((.|\n)*)###'
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_(arc_machine_automanage_configuration_assignment|automanage_configuration|virtual_machine_automanage_configuration_assignment)((.|\n)*)###'

service/automation:
- '### (|New or )Affected Resource\(s\)\/Data Source\(s\)((.|\n)*)azurerm_automation_((.|\n)*)###'
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,165 @@
package automanage

import (
"context"
"fmt"
"time"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-helpers/lang/response"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofileassignments"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofilehcrpassignments"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofiles"
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
"github.com/hashicorp/terraform-provider-azurerm/internal/sdk"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
)

type ArcMachineConfigurationAssignment struct {
ArcMachineId string `tfschema:"arc_machine_id"`
ConfigurationId string `tfschema:"configuration_id"`
}

func (v ArcMachineConfigurationAssignment) Arguments() map[string]*schema.Schema {
return map[string]*schema.Schema{
"arc_machine_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: configurationprofileassignments.ValidateMachineID,
},
"configuration_id": {
Type: schema.TypeString,
Required: true,
ForceNew: true,
ValidateFunc: configurationprofiles.ValidateConfigurationProfileID,
},
}
}

func (v ArcMachineConfigurationAssignment) Attributes() map[string]*schema.Schema {
return map[string]*pluginsdk.Schema{}
}

func (v ArcMachineConfigurationAssignment) ModelObject() interface{} {
return &ArcMachineConfigurationAssignment{}
}

func (v ArcMachineConfigurationAssignment) ResourceType() string {
return "azurerm_arc_machine_automanage_configuration_assignment"
}

func (v ArcMachineConfigurationAssignment) Create() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 30 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.Automanage.ConfigurationProfileArcMachineAssignmentsClient
subscriptionId := metadata.Client.Account.SubscriptionId

var model ArcMachineConfigurationAssignment
if err := metadata.Decode(&model); err != nil {
return fmt.Errorf("decoding: %+v", err)
}

arcMachineId, err := configurationprofileassignments.ParseMachineID(model.ArcMachineId)
if err != nil {
return err
}

configurationId, err := configurationprofiles.ParseConfigurationProfileID(model.ConfigurationId)
if err != nil {
return err
}

// Currently, the configuration profile assignment name has to be hardcoded to "default" by API requirement.
id := configurationprofilehcrpassignments.NewProviders2ConfigurationProfileAssignmentID(subscriptionId, arcMachineId.ResourceGroupName, arcMachineId.MachineName, "default")
katbyte marked this conversation as resolved.
Show resolved Hide resolved
existing, err := client.Get(ctx, id)
if err != nil && !response.WasNotFound(existing.HttpResponse) {
return fmt.Errorf("checking for existing %s: %+v", id, err)
}

if !response.WasNotFound(existing.HttpResponse) {
return metadata.ResourceRequiresImport(v.ResourceType(), id)
}

properties := configurationprofilehcrpassignments.ConfigurationProfileAssignment{
Properties: &configurationprofilehcrpassignments.ConfigurationProfileAssignmentProperties{
ConfigurationProfile: pointer.FromString(configurationId.ID()),
},
}

if _, respErr := client.CreateOrUpdate(ctx, id, properties); respErr != nil {
return fmt.Errorf("creating %s: %+v", id.String(), respErr)
}

metadata.SetID(id)
return nil
},
}
}

func (v ArcMachineConfigurationAssignment) Read() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 5 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.Automanage.ConfigurationProfileArcMachineAssignmentsClient
id, err := configurationprofilehcrpassignments.ParseProviders2ConfigurationProfileAssignmentID(metadata.ResourceData.Id())
if err != nil {
return err
}

resp, err := client.Get(ctx, *id)
if err != nil {
if response.WasNotFound(resp.HttpResponse) {
return metadata.MarkAsGone(id)
}

return fmt.Errorf("retrieving %s: %+v", *id, err)
}

state := ArcMachineConfigurationAssignment{}

if model := resp.Model; model != nil {
configurationId, err := configurationprofiles.ParseConfigurationProfileID(*model.Properties.ConfigurationProfile)
if err != nil {
return err
}
state.ConfigurationId = configurationId.ID()

arcMachineId, err := configurationprofileassignments.ParseMachineID(*model.Properties.TargetId)
if err != nil {
return err
}
state.ArcMachineId = arcMachineId.ID()
}

return metadata.Encode(&state)
},
}
}

func (v ArcMachineConfigurationAssignment) Delete() sdk.ResourceFunc {
return sdk.ResourceFunc{
Timeout: 30 * time.Minute,
Func: func(ctx context.Context, metadata sdk.ResourceMetaData) error {
client := metadata.Client.Automanage.ConfigurationProfileArcMachineAssignmentsClient

id, err := configurationprofilehcrpassignments.ParseProviders2ConfigurationProfileAssignmentID(metadata.ResourceData.Id())
if err != nil {
return err
}

if _, err := client.Delete(ctx, *id); err != nil {
return fmt.Errorf("deleting %s: %+v", id, err)
}

return nil
},
}
}

func (v ArcMachineConfigurationAssignment) IDValidationFunc() pluginsdk.SchemaValidateFunc {
return configurationprofilehcrpassignments.ValidateProviders2ConfigurationProfileAssignmentID
}

var _ sdk.Resource = &ArcMachineConfigurationAssignment{}
Original file line number Diff line number Diff line change
@@ -0,0 +1,83 @@
package automanage_test

import (
"context"
"fmt"
"testing"

"github.com/hashicorp/go-azure-helpers/lang/pointer"
"github.com/hashicorp/go-azure-helpers/lang/response"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofilehcrpassignments"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance"
"github.com/hashicorp/terraform-provider-azurerm/internal/acceptance/check"
"github.com/hashicorp/terraform-provider-azurerm/internal/clients"
"github.com/hashicorp/terraform-provider-azurerm/internal/tf/pluginsdk"
"github.com/hashicorp/terraform-provider-azurerm/utils"
)

type ArcMachineConfigurationAssignmentResource struct{}

func TestAccArcMachineConfigurationAssignment_complete(t *testing.T) {
t.Skip("The deprecation check prevents the creation of a hybrid compute machine resource using os.Getenv(\"ARM_CLIENT_SECRET\")")
data := acceptance.BuildTestData(t, "azurerm_arc_machine_automanage_configuration_assignment", "test")
r := ArcMachineConfigurationAssignmentResource{}
data.ResourceTest(t, r, []acceptance.TestStep{
{
Config: r.complete(data),
Check: acceptance.ComposeTestCheckFunc(
check.That(data.ResourceName).ExistsInAzure(r),
),
},
data.ImportStep(),
})
}

func (r ArcMachineConfigurationAssignmentResource) Exists(ctx context.Context, clients *clients.Client, state *pluginsdk.InstanceState) (*bool, error) {
client := clients.Automanage.ConfigurationProfileArcMachineAssignmentsClient

id, err := configurationprofilehcrpassignments.ParseProviders2ConfigurationProfileAssignmentID(state.ID)
if err != nil {
return nil, err
}

resp, err := client.Get(ctx, *id)
if err != nil {
if response.WasNotFound(resp.HttpResponse) {
return utils.Bool(false), nil
}
return nil, fmt.Errorf("retrieving %s: %+v", id, err)
}
return pointer.To(resp.Model != nil), nil
}

func (r ArcMachineConfigurationAssignmentResource) complete(data acceptance.TestData) string {
return fmt.Sprintf(`
provider "azurerm" {
features {}
}

resource "azurerm_resource_group" "test" {
name = "acctestRG-%d"
location = "%s"
}

data "azurerm_arc_machine" "test" {
name = "arc-test"
resource_group_name = azurerm_resource_group.test.name
depends_on = [
azurerm_linux_virtual_machine.test
]
}

resource "azurerm_automanage_configuration" "test" {
name = "acctest-amcp-%d"
resource_group_name = azurerm_resource_group.test.name
location = azurerm_resource_group.test.location
}

resource "azurerm_arc_machine_automanage_configuration_assignment" "test" {
arc_machine_id = data.azurerm_arc_machine.test.id
configuration_id = azurerm_automanage_configuration.test.id
}
`, data.RandomInteger, data.Locations.Primary, data.RandomInteger)
}
21 changes: 15 additions & 6 deletions internal/services/automanage/client/client.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,14 +8,16 @@ import (

"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofileassignments"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofilehciassignments"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofilehcrpassignments"
"github.com/hashicorp/go-azure-sdk/resource-manager/automanage/2022-05-04/configurationprofiles"
"github.com/hashicorp/terraform-provider-azurerm/internal/common"
)

type Client struct {
ConfigurationProfilesClient *configurationprofiles.ConfigurationProfilesClient
ConfigurationProfileHCIAssignmentsClient *configurationprofilehciassignments.ConfigurationProfileHCIAssignmentsClient
ConfigurationProfileVMAssignmentsClient *configurationprofileassignments.ConfigurationProfileAssignmentsClient
ConfigurationProfilesClient *configurationprofiles.ConfigurationProfilesClient
ConfigurationProfileArcMachineAssignmentsClient *configurationprofilehcrpassignments.ConfigurationProfileHCRPAssignmentsClient
ConfigurationProfileHCIAssignmentsClient *configurationprofilehciassignments.ConfigurationProfileHCIAssignmentsClient
ConfigurationProfileVMAssignmentsClient *configurationprofileassignments.ConfigurationProfileAssignmentsClient
}

func NewClient(o *common.ClientOptions) (*Client, error) {
Expand All @@ -25,6 +27,12 @@ func NewClient(o *common.ClientOptions) (*Client, error) {
}
o.Configure(configurationProfilesClient.Client, o.Authorizers.ResourceManager)

configurationProfileArcMachineAssignmentsClient, err := configurationprofilehcrpassignments.NewConfigurationProfileHCRPAssignmentsClientWithBaseURI(o.Environment.ResourceManager)
if err != nil {
return nil, fmt.Errorf("building ConfigurationProfilesHCIAssignments client: %+v", err)
}
o.Configure(configurationProfileArcMachineAssignmentsClient.Client, o.Authorizers.ResourceManager)

configurationProfileHCIAssignmentsClient, err := configurationprofilehciassignments.NewConfigurationProfileHCIAssignmentsClientWithBaseURI(o.Environment.ResourceManager)
if err != nil {
return nil, fmt.Errorf("building ConfigurationProfilesHCIAssignments client: %+v", err)
Expand All @@ -38,8 +46,9 @@ func NewClient(o *common.ClientOptions) (*Client, error) {
o.Configure(configurationProfileVMAssignmentsClient.Client, o.Authorizers.ResourceManager)

return &Client{
ConfigurationProfilesClient: configurationProfilesClient,
ConfigurationProfileHCIAssignmentsClient: configurationProfileHCIAssignmentsClient,
ConfigurationProfileVMAssignmentsClient: configurationProfileVMAssignmentsClient,
ConfigurationProfilesClient: configurationProfilesClient,
ConfigurationProfileArcMachineAssignmentsClient: configurationProfileArcMachineAssignmentsClient,
ConfigurationProfileHCIAssignmentsClient: configurationProfileHCIAssignmentsClient,
ConfigurationProfileVMAssignmentsClient: configurationProfileVMAssignmentsClient,
}, nil
}
1 change: 1 addition & 0 deletions internal/services/automanage/registration.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,5 +51,6 @@ func (r Registration) Resources() []sdk.Resource {
return []sdk.Resource{
AutoManageConfigurationResource{},
VirtualMachineConfigurationAssignment{},
ArcMachineConfigurationAssignment{},
}
}

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading