fix panic from removed not block (#26724)

internal/services/consumption/consumption_budget_base.go

@@ -700,17 +700,19 @@ func expandConsumptionBudgetFilter(i []interface{}) *budgets.BudgetFilter {
 
 	filter := budgets.BudgetFilter{}
 
-	notBlock := input["not"].([]interface{})
-	if len(notBlock) != 0 && notBlock[0] != nil {
-		not := notBlock[0].(map[string]interface{})
+	if !features.FourPointOhBeta() {
+		notBlock := input["not"].([]interface{})
+		if len(notBlock) != 0 && notBlock[0] != nil {
+			not := notBlock[0].(map[string]interface{})
 
-		tags := expandConsumptionBudgetFilterTag(not["tag"].([]interface{}))
-		dimensions := expandConsumptionBudgetFilterDimensions(not["dimension"].([]interface{}))
+			tags := expandConsumptionBudgetFilterTag(not["tag"].([]interface{}))
+			dimensions := expandConsumptionBudgetFilterDimensions(not["dimension"].([]interface{}))
 
-		if len(dimensions) != 0 {
-			filter.Not = &dimensions[0]
-		} else if len(tags) != 0 {
-			filter.Not = &tags[0]
+			if len(dimensions) != 0 {
+				filter.Not = &dimensions[0]
+			} else if len(tags) != 0 {
+				filter.Not = &tags[0]
+			}
 		}
 	}
 
@@ -754,19 +756,21 @@ func flattenConsumptionBudgetFilter(input *budgets.BudgetFilter) []interface{} {
 
 	filterBlock := make(map[string]interface{})
 
-	notBlock := make(map[string]interface{})
+	if !features.FourPointOhBeta() {
+		notBlock := make(map[string]interface{})
 
-	if input.Not != nil {
-		if input.Not.Dimensions != nil {
-			notBlock["dimension"] = []interface{}{flattenConsumptionBudgetComparisonExpression(input.Not.Dimensions)}
-		}
+		if input.Not != nil {
+			if input.Not.Dimensions != nil {
+				notBlock["dimension"] = []interface{}{flattenConsumptionBudgetComparisonExpression(input.Not.Dimensions)}
+			}
 
-		if input.Not.Tags != nil {
-			notBlock["tag"] = []interface{}{flattenConsumptionBudgetComparisonExpression(input.Not.Tags)}
-		}
+			if input.Not.Tags != nil {
+				notBlock["tag"] = []interface{}{flattenConsumptionBudgetComparisonExpression(input.Not.Tags)}
+			}
 
-		if len(notBlock) != 0 {
-			filterBlock["not"] = []interface{}{notBlock}
+			if len(notBlock) != 0 {
+				filterBlock["not"] = []interface{}{notBlock}
+			}
 		}
 	}
 

internal/services/consumption/consumption_budget_resource_group_resource_test.go

@@ -371,11 +371,9 @@ resource "azurerm_consumption_budget_resource_group" "test" {
   name              = "acctestconsumptionbudgetresourcegroup-%d"
   resource_group_id = azurerm_resource_group.test.id
 
-  // Changed the amount from 1000 to 2000
   amount     = 2000
   time_grain = "Monthly"
 
-  // Removed end_date
   time_period {
     start_date = "%s"
   }
@@ -396,16 +394,13 @@ resource "azurerm_consumption_budget_resource_group" "test" {
       ]
     }
 
-    // Added tag: zip
     tag {
       name = "zip"
       values = [
         "zap",
         "zop",
       ]
     }
-
-    // Removed not block
   }
 
   notification {
@@ -417,7 +412,6 @@ resource "azurerm_consumption_budget_resource_group" "test" {
     threshold_type = "Forecasted"
 
     contact_emails = [
-      // Added [email protected]
       "[email protected]",
       "[email protected]",
       "[email protected]",
@@ -426,22 +420,18 @@ resource "azurerm_consumption_budget_resource_group" "test" {
     contact_groups = [
       azurerm_monitor_action_group.test.id,
     ]
-    // Removed contact_roles
   }
 
   notification {
-    // Set enabled to true
     enabled   = true
     threshold = 100.0
-    // Changed from EqualTo to GreaterThanOrEqualTo 
-    operator = "GreaterThanOrEqualTo"
+    operator  = "GreaterThanOrEqualTo"
 
     contact_emails = [
       "[email protected]",
       "[email protected]",
     ]
 
-    // Added contact_groups
     contact_groups = [
       azurerm_monitor_action_group.test.id,
     ]