Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REMOVE forceful recreation of resource and rely on Cluster Mode Enabl… #6210

Closed
wants to merge 1 commit into from
Closed

REMOVE forceful recreation of resource and rely on Cluster Mode Enabl… #6210

wants to merge 1 commit into from

Conversation

mattclegg
Copy link

…ed online shard reconfiguration #3932

Fixes #0000

Changes proposed in this pull request:

  • Change 1
  • Change 2

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccAWSAvailabilityZones'

...

@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/elasticache Issues and PRs that pertain to the elasticache service. labels Oct 19, 2018
bflad
bflad reviewed Oct 19, 2018
View reviewed changes
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mattclegg 👋 Can you please provide some more context about this change and what you're trying to accomplish that isn't working as expected?

aws/resource_aws_elasticache_replication_group.go
"replicas_per_node_group": 0,
}

if len(nodeGroups) == 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is intentional to prevent a potential index reference panic where nodeGroups does not contain any elements.

@bflad bflad added the waiting-response Maintainers are waiting on response from community or contributor. label Oct 19, 2018
@bflad
Copy link
Contributor

bflad commented Oct 30, 2018

@mattclegg ping ^

@bflad
Copy link
Contributor

bflad commented Nov 13, 2018

It's been a long time since we heard from you here so we're going to close this out. If you're still having this problem, please feel free to open a new issue and complete all of the information requested in the Bug Report template so that we can attempt to understand and reproduce the problem.

@bflad bflad closed this Nov 13, 2018
@ghost
Copy link

ghost commented Apr 2, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 2, 2020
@mattclegg mattclegg deleted the 4817 branch April 3, 2020 01:59
@breathingdust breathingdust removed the waiting-response Maintainers are waiting on response from community or contributor. label Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bflad bflad bflad left review comments

Assignees
No one assigned
Labels
service/elasticache Issues and PRs that pertain to the elasticache service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattclegg @bflad @breathingdust