Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tagging tests for drs #39061

Merged
merged 1 commit into from
Aug 29, 2024
Merged

Tagging tests for drs #39061

merged 1 commit into from
Aug 29, 2024

Conversation

gdavison
Copy link
Contributor

Description

Adds tagging tests for drs.

Previously, when updating aws_drs_replication_configuration_template the error was returned

        Error: Value Conversion Error
        
          with aws_drs_replication_configuration_template.test,
          on main_gen.tf line 10, in resource "aws_drs_replication_configuration_template" "test":
          10: resource "aws_drs_replication_configuration_template" "test" {
        
        An unexpected error was encountered trying to build a value. This is always
        an error in the provider. Please report the following to the provider
        developer:
        
        Received unknown value, however the target type cannot handle unknown values.
        Use the corresponding `types` package type or a custom type that handles
        unknown values.
        
        Path: arn
        Target Type: string
        Suggested Type: basetypes.StringValue

@gdavison gdavison requested a review from a team as a code owner August 27, 2024 23:32
Copy link

Community Note

Voting for Prioritization

  • Please vote on this pull request by adding a 👍 reaction to the original post to help the community and maintainers prioritize this pull request.
  • Please see our prioritization guide for information on how we prioritize.
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.

For Submitters

  • Review the contribution guide relating to the type of change you are making to ensure all of the necessary steps have been taken.
  • For new resources and data sources, use skaff to generate scaffolding with comments detailing common expectations.
  • Whether or not the branch has been rebased will not impact prioritization, but doing so is always a welcome surprise.

@github-actions github-actions bot added tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. tags Pertains to resource tagging. generators Relates to code generators. service/drs Issues and PRs that pertain to the drs service. prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. labels Aug 27, 2024
@gdavison gdavison added the bug Addresses a defect in current functionality. label Aug 29, 2024
Copy link
Member

@jar-b jar-b left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

% make testacc PKG=drs TESTS=TestAccDRSReplicationConfigurationTemplate_serial/tags
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/drs/... -v -count 1 -parallel 20 -run='TestAccDRSReplicationConfigurationTemplate_serial/tags'  -timeout 360m
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial
=== PAUSE TestAccDRSReplicationConfigurationTemplate_serial
=== CONT  TestAccDRSReplicationConfigurationTemplate_serial
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnCreate
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/basic
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/AddOnUpdate
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nonOverlapping
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_overlapping
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToResourceOnly
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_emptyResourceTag
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullOverlappingResourceTag
    replication_configuration_template_tags_gen_test.go:1510: Tags with null values are not correctly handled with the Plugin Framework
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnCreate
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/null
    replication_configuration_template_tags_gen_test.go:229: Tags with null values are not correctly handled with the Plugin Framework
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Add
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Replace
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_providerOnly
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToProviderOnly
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullNonOverlappingResourceTag
    replication_configuration_template_tags_gen_test.go:1574: Tags with null values are not correctly handled with the Plugin Framework
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Replace
=== RUN   TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Add
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial (1518.55s)
    --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags (1518.55s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnCreate (87.84s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/basic (154.65s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/AddOnUpdate (95.45s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nonOverlapping (117.35s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_overlapping (117.89s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToResourceOnly (97.39s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_emptyResourceTag (85.67s)
        --- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullOverlappingResourceTag (0.00s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnCreate (99.32s)
        --- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/null (0.00s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Add (116.63s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Replace (96.91s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_providerOnly (137.12s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToProviderOnly (99.11s)
        --- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_null
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Replace (99.54s)
        --- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Add (108.67s)
PASS
ok      github.com/hashicorp/terraform-provider-aws/internal/service/drs        1524.519s

@gdavison gdavison merged commit eaa75bf into main Aug 29, 2024
40 checks passed
@gdavison gdavison deleted the b-drs-tags branch August 29, 2024 18:07
@github-actions github-actions bot added this to the v5.65.0 milestone Aug 29, 2024
terraform-aws-provider bot pushed a commit that referenced this pull request Aug 29, 2024
Copy link

This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot removed the prioritized Part of the maintainer teams immediate focus. To be addressed within the current quarter. label Aug 29, 2024
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. generators Relates to code generators. service/drs Issues and PRs that pertain to the drs service. tags Pertains to resource tagging. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants