-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tagging tests for drs
#39061
Tagging tests for drs
#39061
Conversation
Community NoteVoting for Prioritization
For Submitters
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% make testacc PKG=drs TESTS=TestAccDRSReplicationConfigurationTemplate_serial/tags
make: Verifying source code with gofmt...
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go1.23.0 test ./internal/service/drs/... -v -count 1 -parallel 20 -run='TestAccDRSReplicationConfigurationTemplate_serial/tags' -timeout 360m
=== RUN TestAccDRSReplicationConfigurationTemplate_serial
=== PAUSE TestAccDRSReplicationConfigurationTemplate_serial
=== CONT TestAccDRSReplicationConfigurationTemplate_serial
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnCreate
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/basic
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/AddOnUpdate
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nonOverlapping
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_overlapping
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToResourceOnly
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_emptyResourceTag
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullOverlappingResourceTag
replication_configuration_template_tags_gen_test.go:1510: Tags with null values are not correctly handled with the Plugin Framework
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnCreate
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/null
replication_configuration_template_tags_gen_test.go:229: Tags with null values are not correctly handled with the Plugin Framework
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Add
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Replace
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_providerOnly
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToProviderOnly
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullNonOverlappingResourceTag
replication_configuration_template_tags_gen_test.go:1574: Tags with null values are not correctly handled with the Plugin Framework
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Replace
=== RUN TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Add
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial (1518.55s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags (1518.55s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnCreate (87.84s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/basic (154.65s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/AddOnUpdate (95.45s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nonOverlapping (117.35s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_overlapping (117.89s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToResourceOnly (97.39s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_emptyResourceTag (85.67s)
--- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_nullOverlappingResourceTag (0.00s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnCreate (99.32s)
--- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/null (0.00s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Add (116.63s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/EmptyTag_OnUpdate_Replace (96.91s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_providerOnly (137.12s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_updateToProviderOnly (99.11s)
--- SKIP: TestAccDRSReplicationConfigurationTemplate_serial/tags/DefaultTags_null
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Replace (99.54s)
--- PASS: TestAccDRSReplicationConfigurationTemplate_serial/tags/ComputedTag_OnUpdate_Add (108.67s)
PASS
ok github.com/hashicorp/terraform-provider-aws/internal/service/drs 1524.519s
This functionality has been released in v5.65.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Description
Adds tagging tests for
drs
.Previously, when updating
aws_drs_replication_configuration_template
the error was returned