Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resolver_endpoint_type argument to aws_route53_resolver_endpoint #34798

Merged
merged 4 commits into from
Jan 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .changelog/34798.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
```release-note:enhancement
resource/aws_route53_resolver_endpoint: Add `resolver_endpoint_type` argument
```

```release-note:enhancement
data-source/aws_route53_resolver_endpoint: Add `resolver_endpoint_type` attribute
```
17 changes: 16 additions & 1 deletion internal/service/route53resolver/endpoint.go
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,12 @@ func ResourceEndpoint() *schema.Resource {
Optional: true,
ValidateFunc: validResolverName,
},
"resolver_endpoint_type": {
Type: schema.TypeString,
Optional: true,
Computed: true,
ValidateFunc: validation.StringInSlice(route53resolver.ResolverEndpointType_Values(), false),
},
"security_group_ids": {
Type: schema.TypeSet,
Required: true,
Expand Down Expand Up @@ -138,6 +144,10 @@ func resourceEndpointCreate(ctx context.Context, d *schema.ResourceData, meta in
input.Protocols = flex.ExpandStringSet(v.(*schema.Set))
}

if v, ok := d.GetOk("resolver_endpoint_type"); ok {
input.ResolverEndpointType = aws.String(v.(string))
}

output, err := conn.CreateResolverEndpointWithContext(ctx, input)

if err != nil {
Expand Down Expand Up @@ -174,6 +184,7 @@ func resourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta inte
d.Set("host_vpc_id", ep.HostVPCId)
d.Set("name", ep.Name)
d.Set("protocols", aws.StringValueSlice(ep.Protocols))
d.Set("resolver_endpoint_type", ep.ResolverEndpointType)
d.Set("security_group_ids", aws.StringValueSlice(ep.SecurityGroupIds))

ipAddresses, err := findResolverEndpointIPAddressesByID(ctx, conn, d.Id())
Expand All @@ -192,7 +203,7 @@ func resourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta inte
func resourceEndpointUpdate(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
conn := meta.(*conns.AWSClient).Route53ResolverConn(ctx)

if d.HasChanges("name", "protocols") {
if d.HasChanges("name", "protocols", "resolver_endpoint_type") {
input := &route53resolver.UpdateResolverEndpointInput{
ResolverEndpointId: aws.String(d.Id()),
}
Expand All @@ -205,6 +216,10 @@ func resourceEndpointUpdate(ctx context.Context, d *schema.ResourceData, meta in
input.Protocols = flex.ExpandStringSet(d.Get("protocols").(*schema.Set))
}

if d.HasChange("resolver_endpoint_type") {
input.ResolverEndpointType = aws.String(d.Get("resolver_endpoint_type").(string))
}

_, err := conn.UpdateResolverEndpointWithContext(ctx, input)

if err != nil {
Expand Down
5 changes: 5 additions & 0 deletions internal/service/route53resolver/endpoint_data_source.go
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,10 @@ func DataSourceEndpoint() *schema.Resource {
Type: schema.TypeString,
Optional: true,
},
"resolver_endpoint_type": {
Type: schema.TypeString,
Computed: true,
},
"status": {
Type: schema.TypeString,
Computed: true,
Expand Down Expand Up @@ -122,6 +126,7 @@ func dataSourceEndpointRead(ctx context.Context, d *schema.ResourceData, meta in
d.Set("name", ep.Name)
d.Set("protocols", aws.StringValueSlice(ep.Protocols))
d.Set("resolver_endpoint_id", ep.Id)
d.Set("resolver_endpoint_type", ep.ResolverEndpointType)
d.Set("status", ep.Status)
d.Set("vpc_id", ep.HostVPCId)

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ func TestAccRoute53ResolverEndpointDataSource_basic(t *testing.T) {
resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
resource.TestCheckResourceAttrPair(datasourceName, "protocols.#", resourceName, "protocols.#"),
resource.TestCheckResourceAttrPair(datasourceName, "resolver_endpoint_id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "resolver_endpoint_type", resourceName, "resolver_endpoint_type"),
resource.TestCheckResourceAttrPair(datasourceName, "vpc_id", resourceName, "host_vpc_id"),
),
},
Expand Down Expand Up @@ -60,7 +61,9 @@ func TestAccRoute53ResolverEndpointDataSource_filter(t *testing.T) {
resource.TestCheckResourceAttrPair(datasourceName, "id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "ip_addresses.#", resourceName, "ip_address.#"),
resource.TestCheckResourceAttrPair(datasourceName, "name", resourceName, "name"),
resource.TestCheckResourceAttrPair(datasourceName, "protocols.#", resourceName, "protocols.#"),
resource.TestCheckResourceAttrPair(datasourceName, "resolver_endpoint_id", resourceName, "id"),
resource.TestCheckResourceAttrPair(datasourceName, "resolver_endpoint_type", resourceName, "resolver_endpoint_type"),
resource.TestCheckResourceAttrPair(datasourceName, "vpc_id", resourceName, "host_vpc_id"),
),
},
Expand Down
93 changes: 93 additions & 0 deletions internal/service/route53resolver/endpoint_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ func TestAccRoute53ResolverEndpoint_basic(t *testing.T) {
resource.TestCheckResourceAttr(resourceName, "ip_address.#", "3"),
resource.TestCheckResourceAttr(resourceName, "name", ""),
resource.TestCheckResourceAttr(resourceName, "protocols.#", "1"),
resource.TestCheckResourceAttr(resourceName, "resolver_endpoint_type", "IPV4"),
resource.TestCheckResourceAttr(resourceName, "security_group_ids.#", "2"),
resource.TestCheckResourceAttr(resourceName, "tags.%", "0"),
),
Expand Down Expand Up @@ -162,6 +163,36 @@ func TestAccRoute53ResolverEndpoint_updateOutbound(t *testing.T) {
})
}

func TestAccRoute53ResolverEndpoint_resolverEndpointType(t *testing.T) {
ctx := acctest.Context(t)
var ep route53resolver.ResolverEndpoint
resourceName := "aws_route53_resolver_endpoint.test"
rName := sdkacctest.RandomWithPrefix(acctest.ResourcePrefix)

resource.ParallelTest(t, resource.TestCase{
PreCheck: func() { acctest.PreCheck(ctx, t); testAccPreCheck(ctx, t) },
ErrorCheck: acctest.ErrorCheck(t, route53resolver.EndpointsID),
ProtoV5ProviderFactories: acctest.ProtoV5ProviderFactories,
CheckDestroy: testAccCheckEndpointDestroy(ctx),
Steps: []resource.TestStep{
{
Config: testAccEndpointConfig_resolverEndpointType(rName, "DUALSTACK"),
Check: resource.ComposeTestCheckFunc(
testAccCheckEndpointExists(ctx, resourceName, &ep),
resource.TestCheckResourceAttr(resourceName, "resolver_endpoint_type", "DUALSTACK"),
),
},
{
Config: testAccEndpointConfig_resolverEndpointType(rName, "IPV4"),
Check: resource.ComposeTestCheckFunc(
testAccCheckEndpointExists(ctx, resourceName, &ep),
resource.TestCheckResourceAttr(resourceName, "resolver_endpoint_type", "IPV4"),
),
},
},
})
}

func testAccCheckEndpointDestroy(ctx context.Context) resource.TestCheckFunc {
return func(s *terraform.State) error {
conn := acctest.Provider.Meta().(*conns.AWSClient).Route53ResolverConn(ctx)
Expand Down Expand Up @@ -385,3 +416,65 @@ resource "aws_route53_resolver_endpoint" "test" {
}
`, name))
}

func testAccEndpointConfig_resolverEndpointType(rName, resolverEndpointType string) string {
return acctest.ConfigCompose(acctest.ConfigAvailableAZsNoOptIn(), fmt.Sprintf(`
resource "aws_vpc" "test" {
cidr_block = "10.0.0.0/16"
enable_dns_support = true
enable_dns_hostnames = true

assign_generated_ipv6_cidr_block = true

tags = {
Name = %[1]q
}
}

resource "aws_subnet" "test" {
count = 3

vpc_id = aws_vpc.test.id
availability_zone = data.aws_availability_zones.available.names[count.index]
cidr_block = cidrsubnet(aws_vpc.test.cidr_block, 8, count.index)

ipv6_cidr_block = cidrsubnet(aws_vpc.test.ipv6_cidr_block, 8, count.index)
assign_ipv6_address_on_creation = true

tags = {
Name = %[1]q
}
}

resource "aws_security_group" "test" {
count = 2

vpc_id = aws_vpc.test.id
name = "%[1]s-${count.index}"

tags = {
Name = %[1]q
}
}

resource "aws_route53_resolver_endpoint" "test" {
direction = "INBOUND"

security_group_ids = aws_security_group.test[*].id

ip_address {
subnet_id = aws_subnet.test[0].id
}

ip_address {
subnet_id = aws_subnet.test[1].id
}

ip_address {
subnet_id = aws_subnet.test[2].id
}

resolver_endpoint_type = %[2]q
}
`, rName, resolverEndpointType))
}
3 changes: 2 additions & 1 deletion website/docs/d/route53_resolver_endpoint.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,8 @@ In addition to all arguments above, the following attributes are exported:
* `arn` - Computed ARN of the Route53 Resolver Endpoint.
* `direction` - Direction of the queries to or from the Resolver Endpoint .
* `ip_addresses` - List of IPaddresses that have been associated with the Resolver Endpoint.
* `protocols` - The protocols used by Resolver endpoint.
* `protocols` - The protocols used by the Resolver endpoint.
* `resolver_endpoint_type` - The Resolver endpoint IP address type.
* `status` - Current status of the Resolver Endpoint.
* `vpc_id` - ID of the Host VPC that the Resolver Endpoint resides in.

Expand Down
1 change: 1 addition & 0 deletions website/docs/r/route53_resolver_endpoint.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@ to your network (for outbound endpoints) or on the way from your network to your
* `security_group_ids` - (Required) The ID of one or more security groups that you want to use to control access to this VPC.
* `name` - (Optional) The friendly name of the Route 53 Resolver endpoint.
* `protocols` - (Optional) The protocols you want to use for the Route 53 Resolver endpoint. Valid values: `DoH`, `Do53`, `DoH-FIPS`.
* `resolver_endpoint_type` - (Optional) The Route 53 Resolver endpoint IP address type. Valid values: `IPV4`, `IPV6`, `DUALSTACK`.
* `tags` - (Optional) A map of tags to assign to the resource. If configured with a provider [`default_tags` configuration block](https://registry.terraform.io/providers/hashicorp/aws/latest/docs#default_tags-configuration-block) present, tags with matching keys will overwrite those defined at the provider-level.

The `ip_address` object supports the following:
Expand Down