add data source for aws_servicecatalog_provisioning_artifacts

[silvaalbert]

Community Note

• Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Closes #25531

Output from acceptance testing:

$ make testacc TESTS='TestAccServiceCatalogProvisioningArtifactsDataSource_basic' PKG=servicecatalog TESTARGS=-short
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 20 -run='TestAccServiceCatalogProvisioningArtifactsDataSource_basic' -short -timeout 180m
=== RUN   TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== CONT  TestAccServiceCatalogProvisioningArtifactsDataSource_basic
--- PASS: TestAccServiceCatalogProvisioningArtifactsDataSource_basic (36.03s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	38.528s

...

[owenfarrell]

@silvaalbert - how would you feel about splitting the list of provisioning_artifact_details in to active_provisioning_artifact (a scalar) and inactive_provisioning_artifacts (a list)?

Reason I mention that is because I think the use cases for referencing the active product are going to outweigh the rest of the products... and finding the active element via a for expression will have limitations.

[vanveele]

Is there anything blocking this PR?
The feature as it is implemented here would be useful to me.

[pdahake]

This would help us with our end to end automation.

[ewbankkit]

LGTM 🚀.

% make testacc TESTARGS='-run=TestAccServiceCatalogProvisioningArtifactsDataSource_' PKG=servicecatalog ACCTEST_PARALLELISM=3
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./internal/service/servicecatalog/... -v -count 1 -parallel 3  -run=TestAccServiceCatalogProvisioningArtifactsDataSource_ -timeout 180m
=== RUN   TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== PAUSE TestAccServiceCatalogProvisioningArtifactsDataSource_basic
=== CONT  TestAccServiceCatalogProvisioningArtifactsDataSource_basic
--- PASS: TestAccServiceCatalogProvisioningArtifactsDataSource_basic (36.56s)
PASS
ok  	github.com/hashicorp/terraform-provider-aws/internal/service/servicecatalog	41.917s

[ewbankkit]

@silvaalbert Thanks for the contribution 🎉 👏.

[github-actions]

This functionality has been released in v4.59.0 of the Terraform AWS Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.