-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ip_address_type to lb_target_group #21973
add ip_address_type to lb_target_group #21973
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Welcome @ogonzalez-sd 👋
It looks like this is your first Pull Request submission to the Terraform AWS Provider! If you haven’t already done so please make sure you have checked out our CONTRIBUTING guide and FAQ to make sure your contribution is adhering to best practice and has all the necessary elements in place for a successful approval.
Also take a look at our FAQ which details how we prioritize Pull Requests for inclusion.
Thanks again, and welcome to the community! 😃
…eadersEnabled the only valid value is "ipv4"
the only valid value is "ipv4"
Is there anything else needed to get this PR merged? We need this feature to use IPv6 target groups. |
None that I'm aware of, just waiting on maintainers. But if there is anything I missed in my PR submission, let me know! |
What is needed to get this merged? We really need this feature as well. |
We’re also dependent on this PR. If a maintainer passes by and can have a look at it, it would be awesome 😉 |
+1 we're in need of IPv6 support on NLB target groups, would appreciate seeing this one merged and released. |
Hello Yann could you please put a thumbs in the top comment? That way we can get the maintainers to view this PR. Thank you! |
Hello Adam could you please put a thumbs in the top comment? That way we can get the maintainers to view this PR. Thank you! |
Any updates on this one, manually provisioning target groups is becoming increasingly problematic? |
Yup, looks superseded by #26320 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Add
ip_address_type
tolb_target_group
resource and data source.From https://docs.aws.amazon.com/elasticloadbalancing/latest/network/load-balancer-target-groups.html#target-group-ip-address-type
IP address type
When creating a new target group, you can select the IP address type of your target group. This controls the IP version used to communicate with targets and check their health status.
Network Load Balancers support both IPv4 and IPv6 target groups. The default selection is IPv4. IPv6 target groups can only be associated with dualstack Network Load Balancers.
Considerations
All IP addresses within a target group must have the same IP address type. For example, you can't register an IPv4 target with an IPv6 target group.
IPv6 target groups can only be used with dualstack load balancers with TCP or a TLS listeners.
IPv6 target groups only support IP type targets.
Community Note
Release notes for CHANGELOG:
Output from acceptance testing: