Skip to content

Commit

Permalink
Increase Dataview operation Timeouts to match the FinSpace API. (#35207)
Browse files Browse the repository at this point in the history
* Increase Dataview operation Timeouts to match the FinSpace API.

* r/aws_finspace_kx_dataview(doc): update default timeout values

* chore: changelog

---------

Co-authored-by: Jared Baker <[email protected]>
  • Loading branch information
hiranimd and jar-b authored Jan 9, 2024
1 parent 43a9d8d commit a81937c
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 6 deletions.
3 changes: 3 additions & 0 deletions .changelog/35207.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:enhancement
resource/aws_finspace_kx_dataview: Increase default create, update, and delete timeouts to 4 hours
```
6 changes: 3 additions & 3 deletions internal/service/finspace/kx_dataview.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,9 @@ func ResourceKxDataview() *schema.Resource {
},

Timeouts: &schema.ResourceTimeout{
Create: schema.DefaultTimeout(30 * time.Minute),
Update: schema.DefaultTimeout(30 * time.Minute),
Delete: schema.DefaultTimeout(30 * time.Minute),
Create: schema.DefaultTimeout(4 * time.Hour),
Update: schema.DefaultTimeout(4 * time.Hour),
Delete: schema.DefaultTimeout(4 * time.Hour),
},
Schema: map[string]*schema.Schema{
"arn": {
Expand Down
14 changes: 11 additions & 3 deletions website/docs/r/finspace_kx_dataview.html.markdown
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ resource "aws_finspace_kx_dataview" "example" {
volume_name = aws_finspace_kx_volume.example.name
db_paths = ["/*"]
}
# Depending on the type of cache and size of the Kx Volume, create/update timeouts
# may need to be increased up to a potential maximum of 24 hours and the delete timeout to 12 hours.
timeouts {
create = "24h"
update = "24h"
delete = "12h"
}
}
```

Expand Down Expand Up @@ -70,9 +78,9 @@ This resource exports the following attributes in addition to the arguments abov

[Configuration options](https://developer.hashicorp.com/terraform/language/resources/syntax#operation-timeouts):

* `create` - (Default `30m`)
* `update` - (Default `30m`)
* `delete` - (Default `30m`)
* `create` - (Default `4h`)
* `update` - (Default `4h`)
* `delete` - (Default `4h`)

## Import

Expand Down

0 comments on commit a81937c

Please sign in to comment.