Merge pull request #24170 from DrFaust92/grafana-validations

r/grafana_workspace - validations
hashicorp · Apr 12, 2022 · 65d0933 · 65d0933
2 parents 2617987 + 6f17f74
commit 65d0933
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 3 deletions.
diff --git a/.changelog/24170.txt b/.changelog/24170.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_grafana_workspace: Add plan time validations for `authentication_providers`, `authentication_providers`, `authentication_providers`.
+```
diff --git a/internal/service/grafana/workspace.go b/internal/service/grafana/workspace.go
@@ -48,12 +48,18 @@ func ResourceWorkspace() *schema.Resource {
 				Type:     schema.TypeList,
 				Required: true,
 				ForceNew: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
+				Elem: &schema.Schema{
+					Type:         schema.TypeString,
+					ValidateFunc: validation.StringInSlice(managedgrafana.AuthenticationProviderTypes_Values(), false),
+				},
 			},
 			"data_sources": {
 				Type:     schema.TypeList,
 				Optional: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
+				Elem: &schema.Schema{
+					Type:         schema.TypeString,
+					ValidateFunc: validation.StringInSlice(managedgrafana.DataSourceType_Values(), false),
+				},
 			},
 			"description": {
 				Type:     schema.TypeString,
@@ -75,7 +81,10 @@ func ResourceWorkspace() *schema.Resource {
 			"notification_destinations": {
 				Type:     schema.TypeList,
 				Optional: true,
-				Elem:     &schema.Schema{Type: schema.TypeString},
+				Elem: &schema.Schema{
+					Type:         schema.TypeString,
+					ValidateFunc: validation.StringInSlice(managedgrafana.NotificationDestinationType_Values(), false),
+				},
 			},
 			"organization_role_name": {
 				Type:     schema.TypeString,