Merge pull request #29721 from hashicorp/f-aws_lambda_function-valida…

…tion `r/aws_lambda_function`: Add `memory_size`, `role`, and `timeout` validation
hashicorp · Mar 2, 2023 · 0a07124 · 0a07124
2 parents 859c562 + 240fff1
commit 0a07124
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 8 deletions.
diff --git a/.changelog/29721.txt b/.changelog/29721.txt
@@ -0,0 +1,3 @@
+```release-note:enhancement
+resource/aws_lambda_function: Add plan time validators for `memory_size`, `role`, and `timeout`
+```
diff --git a/internal/service/lambda/function.go b/internal/service/lambda/function.go
@@ -219,9 +219,10 @@ func ResourceFunction() *schema.Resource {
 				},
 			},
 			"memory_size": {
-				Type:     schema.TypeInt,
-				Optional: true,
-				Default:  128,
+				Type:         schema.TypeInt,
+				Optional:     true,
+				Default:      128,
+				ValidateFunc: validation.IntBetween(128, 10240),
 			},
 			"package_type": {
 				Type:             schema.TypeString,
@@ -260,8 +261,9 @@ func ResourceFunction() *schema.Resource {
 				ValidateFunc: validation.IntAtLeast(-1),
 			},
 			"role": {
-				Type:     schema.TypeString,
-				Required: true,
+				Type:         schema.TypeString,
+				Required:     true,
+				ValidateFunc: verify.ValidARN,
 			},
 			"runtime": {
 				Type:             schema.TypeString,
@@ -327,9 +329,10 @@ func ResourceFunction() *schema.Resource {
 			"tags":     tftags.TagsSchema(),
 			"tags_all": tftags.TagsSchemaComputed(),
 			"timeout": {
-				Type:     schema.TypeInt,
-				Optional: true,
-				Default:  3,
+				Type:         schema.TypeInt,
+				Optional:     true,
+				Default:      3,
+				ValidateFunc: validation.IntBetween(1, 900),
 			},
 			"tracing_config": {
 				Type:     schema.TypeList,