Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

client: Return empty values when host stats fail #6349

Merged
merged 3 commits into from
Nov 20, 2019
Merged

client: Return empty values when host stats fail #6349

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b183e5
client: Return empty values when host stats fail
endocrimes Sep 18, 2019
c8ba938
client_stats: Always emit client stats
endocrimes Sep 18, 2019
4ba87cc
command: Improve metrics fail logging
endocrimes Sep 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
command: Improve metrics fail logging
  • Loading branch information
@endocrimes
endocrimes committed Sep 19, 2019
commit 4ba87cc77aeb003ec1a7af4c2d25055c9c6d9db8
2 changes: 1 addition & 1 deletion command/agent/metrics_endpoint_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ func TestHTTP_FreshClientAllocMetrics(t *testing.T) {
terminal == float32(numTasks), nil
}, func(err error) {
require.Fail("timed out waiting for metrics to converge",
"pending: %v, running: %v, terminal: %v", pending, running, terminal)
"expected: (pending: 0, running: 0, terminal: %v), got: (pending: %v, running: %v, terminal: %v)", numTasks, pending, running, terminal)
})
})
}