Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node events #3945

Merged
merged 19 commits into from
Mar 14, 2018
Merged

Add node events #3945

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
365d47c
NodeEvents struct
chelseakomlo Feb 28, 2018
f051d43
RPC, FSM, state store for Node.EmitEvent
chelseakomlo Mar 1, 2018
55e0c7d
fix up error logging
chelseakomlo Mar 6, 2018
de6199a
move adding node registration event to the state store
chelseakomlo Mar 7, 2018
551e96f
code review feedback
chelseakomlo Mar 8, 2018
fc81975
Ensure node updates don't strip node events
chelseakomlo Mar 8, 2018
56f5e66
add node id to tests; check for node events in state store
chelseakomlo Mar 8, 2018
cbbb60a
move all structs to structs file
chelseakomlo Mar 8, 2018
705ff98
code review feedback
chelseakomlo Mar 8, 2018
55670c8
batch submitting node events
chelseakomlo Mar 9, 2018
a72dcbf
add client side emitting of node events
chelseakomlo Mar 9, 2018
9ef6ad0
fix up go check warnings
chelseakomlo Mar 9, 2018
3f561c3
keep state store functions in one file
chelseakomlo Mar 11, 2018
6eb9911
code review feedback
chelseakomlo Mar 12, 2018
3a1043d
make check fixes
chelseakomlo Mar 12, 2018
319f809
code review feedback
chelseakomlo Mar 13, 2018
57ddd51
fixes
dadgar Mar 14, 2018
eceabb6
nodeevents -> events
dadgar Mar 14, 2018
8ba5ba3
small cleanup
dadgar Mar 14, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
make check fixes
  • Loading branch information
@chelseakomlo @dadgar
chelseakomlo authored and dadgar committed Mar 14, 2018
commit 3a1043def921e9e786a94719aa22c72b2c02f668
4 changes: 2 additions & 2 deletions nomad/state/state_store_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6494,7 +6494,7 @@ func TestStateStore_AddSingleNodeEvent(t *testing.T) {
Timestamp: time.Now().Unix(),
}
nodeEvents := map[string][]*structs.NodeEvent{
node.ID: []*structs.NodeEvent{nodeEvent},
node.ID: {nodeEvent},
}
err = state.AddNodeEvent(uint64(1001), nodeEvents)
require.Nil(err)
Expand Down Expand Up @@ -6538,7 +6538,7 @@ func TestStateStore_NodeEvents_RetentionWindow(t *testing.T) {
}

nodeEvents := map[string][]*structs.NodeEvent{
out.ID: []*structs.NodeEvent{nodeEvent},
out.ID: {nodeEvent},
}
err := state.AddNodeEvent(uint64(i), nodeEvents)
require.Nil(err)
Expand Down