Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Heartbeat improvements and handling failures during establishing leadership #3890

Merged
merged 9 commits into from
Mar 12, 2018
Merged

Heartbeat improvements and handling failures during establishing leadership #3890

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f970e3d
Registering back to initializing
dadgar Feb 17, 2018
50ac3f1
Add escape hatches when non-leader
dadgar Feb 20, 2018
9f64e36
timers
dadgar Feb 20, 2018
a62f8ae
Fix leaking time.After function
dadgar Feb 20, 2018
f1877e3
Need to revoke leadership to clean up in case there was a failure dur…
dadgar Feb 20, 2018
cb6a697
add a revoke leadership test
dadgar Feb 20, 2018
08353e8
Fix flaky test
dadgar Feb 21, 2018
ebfd203
logging
dadgar Feb 21, 2018
a013782
Pull in new autopilot
dadgar Feb 21, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix flaky test
  • Loading branch information
@dadgar
dadgar committed Feb 21, 2018
commit 08353e87230a136a6448ba5973e38d350abd48b4
6 changes: 4 additions & 2 deletions nomad/heartbeat_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,9 +271,11 @@ func TestHeartbeat_Server_HeartbeatTTL_Failover(t *testing.T) {
leader.Shutdown()

// heartbeatTimers should be cleared on leader shutdown
if len(leader.heartbeatTimers) != 0 {
testutil.WaitForResult(func() (bool, error) {
return len(leader.heartbeatTimers) == 0, nil
}, func(err error) {
t.Fatalf("heartbeat timers should be empty on the shutdown leader")
}
})

// Find the new leader
testutil.WaitForResult(func() (bool, error) {
Expand Down