Backport of plugins: fix nomadTopologyToProto panic on systems that don't support NUMA into release/1.8.x #23518
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hc-github-team-nomad-core
force-pushed
the
backport/b-win11-startup-panic/violently-lasting-vervet
branch
from
3c05f5d to
396b747
Compare
pkazmierczak
approved these changes
Jul 9, 2024
pkazmierczak
deleted the
backport/b-win11-startup-panic/violently-lasting-vervet
branch
|
I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This PR is auto-generated from #23399 to be assessed for backporting due to the inclusion of the label backport/1.8.x.
The below text is copied from the body of the original PR.
After changes introduced in #23284 we no longer need to make a
if !st.SupportsNUMA()check in theGetNodes()topology method. In fact this check will now cause panic innomadTopologyToProtomethod on systems that don't support NUMA.Fixes #23385
Internal ref: https://hashicorp.atlassian.net/browse/NET-10134
Overview of commits