Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent kill_timeout greater than progress_deadline #16761

Merged
merged 6 commits into from
Apr 4, 2023
Merged

Prevent kill_timeout greater than progress_deadline #16761

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
49d265b
func: add validation for kill timeout smaller than progress dealine
Juanadelacuesta Apr 4, 2023
72567be
style: add changelog
Juanadelacuesta Apr 3, 2023
4052150
style: typo in changelog
Juanadelacuesta Apr 4, 2023
af22534
style: remove refactored test
Juanadelacuesta Apr 4, 2023
dbab6e1
Update .changelog/16761.txt
Juanadelacuesta Apr 4, 2023
698ee3d
Update nomad/structs/structs.go
Juanadelacuesta Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update nomad/structs/structs.go 
Co-authored-by: James Rasell <[email protected]>
  • Loading branch information
@Juanadelacuesta @jrasell
Juanadelacuesta and jrasell authored Apr 4, 2023
commit 698ee3d99c91d0f5fc8c1398a6dfc153fcfccdff
2 changes: 1 addition & 1 deletion nomad/structs/structs.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5139,7 +5139,7 @@ func (u *UpdateStrategy) IsEmpty() bool {
// When the Job is transformed from api to struct, the Update Strategy block is
// copied into the existing task groups, the only things that are passed along
// are MaxParallel and Stagger, because they are enforced at job level.
// That is why checking if MaxParallel is cero is enough to know if the
// That is why checking if MaxParallel is zero is enough to know if the
// update block is empty.

return u.MaxParallel == 0
Expand Down