Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lifecycle: unit test for lifecycle task behavior on restarts #10785

Closed
wants to merge 1 commit into from

Conversation

tgross
Copy link
Member

@tgross tgross commented Jun 18, 2021

Work-in-progress PR for discussion with @isabeldepapel while we work on the collection of work in #9464 #9841 #9840 #10017 #10578 (cc @jazzyfresh as a heads up)

  • This test is incomplete but the goal is that it sets up a job with all the various lifecycle tasks and then will trigger each of the possible behaviors that @isabeldepapel identifies in the flowchart she's working on, and asserts the resulting restart behavior.
  • I've done a bit of refactoring to reuse this mock generator for some other LifecycleAlloc tests, without trying to go all-in on it.

@tgross tgross self-assigned this Jun 18, 2021
@tgross tgross force-pushed the b-lifecycle-testing branch from 1dd8983 to 42c39e0 Compare June 18, 2021 19:29
@vercel vercel bot temporarily deployed to Preview – nomad June 18, 2021 19:29 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from 42c39e0 to 6a48bfa Compare June 18, 2021 19:37
@vercel vercel bot temporarily deployed to Preview – nomad June 18, 2021 19:37 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from 6a48bfa to be7170d Compare June 18, 2021 20:14
@vercel vercel bot temporarily deployed to Preview – nomad June 18, 2021 20:14 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from be7170d to 9aa87df Compare June 21, 2021 13:49
@vercel vercel bot temporarily deployed to Preview – nomad June 21, 2021 13:49 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from 9aa87df to a06669f Compare June 21, 2021 19:35
@vercel vercel bot temporarily deployed to Preview – nomad June 21, 2021 19:35 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from a06669f to 3ca0645 Compare June 21, 2021 20:27
@vercel vercel bot temporarily deployed to Preview – nomad June 21, 2021 20:27 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from 3ca0645 to 34d3548 Compare June 21, 2021 20:28
@vercel vercel bot temporarily deployed to Preview – nomad June 21, 2021 20:28 Inactive
@tgross tgross force-pushed the b-lifecycle-testing branch from 34d3548 to 70f7f47 Compare June 28, 2021 14:26
@vercel vercel bot temporarily deployed to Preview – nomad June 28, 2021 14:26 Inactive
Test the restart behavior of tasks with lifecycles when the allocation or
tasks are restarted.
@tgross tgross force-pushed the b-lifecycle-testing branch from 70f7f47 to 408e5e7 Compare July 2, 2021 14:13
@vercel vercel bot temporarily deployed to Preview – nomad July 2, 2021 14:13 Inactive
@hashicorp-cla
Copy link

hashicorp-cla commented Mar 12, 2022

CLA assistant check
All committers have signed the CLA.

@tgross tgross removed the request for review from jazzyfresh July 22, 2022 13:15
@tgross tgross assigned lgfa29 and unassigned jazzyfresh Jul 22, 2022
@lgfa29
Copy link
Contributor

lgfa29 commented Aug 18, 2022

This work has been incorporated into #14127, thanks!

@lgfa29 lgfa29 closed this Aug 18, 2022
@lgfa29 lgfa29 deleted the b-lifecycle-testing branch August 18, 2022 01:26
@lgfa29 lgfa29 mentioned this pull request Aug 18, 2022
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 120 days ⏳. This helps our maintainers find and focus on the active contributions.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants