Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🛠️ Fix flaky workspace notification tests #312

Merged
merged 1 commit into from
Jan 4, 2024
Merged

🛠️ Fix flaky workspace notification tests #312

merged 1 commit into from
Jan 4, 2024

Conversation

arybolovlev
Copy link
Contributor

@arybolovlev arybolovlev commented Dec 27, 2023 •
edited
Loading

Description

Weekly E2E workspace notification tests fail when the list of notifications received from TFC has a different order than notifications in the CR spec, even though all elements match (the slice has the same size, but elements are ordered differently).

This PR fixes this issue.

Usage Example

N/A.

Release Note

Release note for CHANGELOG:

NONE

References

Fix: #311

Community Note

  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request.
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment.

@github-actions github-actions bot added controller documentation Improvements or additions to documentation golang test size/M labels Dec 27, 2023
@arybolovlev arybolovlev marked this pull request as ready for review December 27, 2023 09:00
@arybolovlev arybolovlev requested a review from a team as a code owner December 27, 2023 09:00
jrhouston
jrhouston requested changes Jan 3, 2024
View reviewed changes
@github-actions github-actions bot added size/L and removed size/M labels Jan 4, 2024
@arybolovlev arybolovlev force-pushed the fix-flaky-tests branch 3 times, most recently from 9e2f31f to ee31766 Compare January 4, 2024 19:22
@github-actions github-actions bot added dependencies Pull requests that update a dependency file size/S and removed size/L labels Jan 4, 2024
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label Jan 4, 2024
@arybolovlev arybolovlev requested a review from jrhouston January 4, 2024 20:27
@arybolovlev arybolovlev merged commit 04eabb8 into main Jan 4, 2024
5 checks passed
@arybolovlev arybolovlev deleted the fix-flaky-tests branch January 4, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhouston jrhouston jrhouston approved these changes

Assignees
No one assigned
Labels
controller documentation Improvements or additions to documentation golang size/S test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 Flaky E2E tests
2 participants
@arybolovlev @jrhouston