Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore feature using syscall for appengine users #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tutuming
Copy link

@tutuming tutuming commented Feb 14, 2017

for #38

go-metrics is imported from goa ( https://github.com/goadesign/goa ) and some users (including me) use appengine to serve APIs.

Build for appengine failed because import of syscall package is not allowed.
So for the appengine users, ignoring the InmemSignal feature make them happy.

@pei0804
Copy link

pei0804 commented Mar 29, 2017

I hope this request will be merged soon

@ryanuber
Copy link
Member

This seems fine to me. Can you also add a note to the README that the InmemSignal is not supported on this platform?

@pei0804
Copy link

pei0804 commented Mar 30, 2017

Go-app-builder: Failed parsing input: parser: bad import "syscall" in ...
This problem is a problem occurring in GAE which is PaaS of GCP.
Two packages, syscall and unsafe, are not allowed to be used on GAE.
So, you need a description not included in the build.

The target files are as follows.

  • const_unix.go
  • const_windows.go
  • inmem_signal.go
  • inmem_signal_test.go

We have created a request.
Verification please.
#47

@hashicorp-cla
Copy link

CLA assistant check

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

Have you signed the CLA already but the status is still pending? Recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants