Remove unused interface methods #117
Open
+38
−218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnephin
force-pushed
the
remove-unused-interface-methods
branch
from
be62836 to
2c01865
Compare
With the addition of labels in hashicorp#54 the Metrics struct only uses the new WithLabels methods on Sink. This change removes the unused methods.
dnephin
force-pushed
the
remove-unused-interface-methods
branch
from
2c01865 to
afd8928
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of labels in #54 only the new
WithLabelsmethods onSinkare used bygo-metrics.My understanding is that this should be a backwards compatible change, because
Sinkis the interface accepted bymetrics.New. Implementations of aSinkoutside of this package would continue to work, and new one would no longer need to implement the 3 unused methods. Nothing outside of this package should call theSinkmethods directly, they would call the methods onMetrics, which have not changed.