Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ui tests run is fixed (applying class attribute twice to the hbs… #16428

Merged
merged 2 commits into from
Feb 25, 2023
Merged

fix: ui tests run is fixed (applying class attribute twice to the hbs… #16428

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6e24f6b
fix: ui tests run is fixed (applying class attribute twice to the hbs…
valeriia-ruban Feb 25, 2023
e5c2537
added changelog
valeriia-ruban Feb 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/16428.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
ui: fixes ui tests run on CI
```
2 changes: 1 addition & 1 deletion ui/packages/consul-ui/app/components/consul/intention/notice/custom-resource/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Hds::Alert @type='inline' @color={{or @type "neutral"}} class='mb-2 mt-2' as |A|>
<Hds::Alert @type='inline' @color={{or @type "neutral"}} class='mb-2 mt-2 consul-intention-notice-custom-resource' as |A|>
<A.Title>Intention Custom Resource</A.Title>
<A.Description>Some of your intentions are being managed through an Intention Custom Resource in your Kubernetes cluster. Those managed intentions will be view only in the UI. Any intentions created in the UI will work but will not be synced to the Custom Resource Definition (CRD) datastore.</A.Description>
<A.Link::Standalone @href="{{env 'CONSUL_DOCS_URL'}}/k8s/crds"
Expand Down
2 changes: 1 addition & 1 deletion ui/packages/consul-ui/app/components/consul/node/agentless-notice/index.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{#if isVisible}}
<Hds::Alert @type="inline" class='mb-3 mt-2' class='agentless-node-notice' data-test-node-agentless-notice as |A|>
<Hds::Alert @type="inline" class='mb-3 mt-2 agentless-node-notice' data-test-node-agentless-notice as |A|>
<A.Title>
<span>{{t 'routes.dc.nodes.index.agentless.notice.header'}}</span>
<Hds::Button
Expand Down