chore: remove unnecessary await
#821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #821 +/- ##
==========================================
- Coverage 77.83% 77.54% -0.30%
==========================================
Files 47 41 -6
Lines 4286 2979 -1307
Branches 611 667 +56
==========================================
- Hits 3336 2310 -1026
+ Misses 933 667 -266
+ Partials 17 2 -15 ☔ View full report in Codecov by Sentry. |
logotip4ik
reviewed
Jul 9, 2024
| @@ -85,7 +85,7 @@ class H3App implements App { | |||
| const val = await layer.handler(event); | |||
|
|
|||
| // 5. Handle response | |||
| const _body = val === undefined ? undefined : await val; | |||
| const _body = val === undefined ? undefined : val; | |||
There was a problem hiding this comment.
if we remove await here, maybe we don't even need this ternary ?
|
changed after #822 |
|
Thanks @pi0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here
valis already awaited. In the next line in_bodyfor conditional checking, we have givenawaitagain for val. Also the code editor is saying await has no effect here like that. That's why I thought may be we may remove it.