Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Water Level Page #2701

Open
10 of 12 tasks
Adelle-Pitsas opened this issue Dec 6, 2023 · 9 comments
Open
10 of 12 tasks

Water Level Page #2701

Adelle-Pitsas opened this issue Dec 6, 2023 · 9 comments
Assignees

Comments

@Adelle-Pitsas
Copy link
Contributor

Adelle-Pitsas commented Dec 6, 2023

Tasks

Preview Give feedback
  1. Adelle-Pitsas
  2. Adelle-Pitsas
@Adelle-Pitsas Adelle-Pitsas self-assigned this Dec 6, 2023
@youngmorse
Copy link

Since the WL product requirements are starting coalesce in the CIVIC Box folder I'll just add a few more links vs. recreating so we don't have to update in more than one place. Hannah made a V2 of the Product Requirements doc to outline basic functionality for both the NERACOOS/Mariners viewer and the EcoINet viewer: CIVIC WL Products

Somewhere in that doc is a link to 'data sources' which is a Google sheet where I started compiling the info on the gauges/sensors - including the benchmark references for flooding levels that will end up on the charts: Google Sheet w/Sensor Info

Revised sketch up of product:
IMG_4724

An example on NOAA Inundation Dashboard of a chart (also in HighCharts!) that shows the benchmarks for flooding levels:
Screen Shot 2023-12-06 at 3 43 39 PM

@tshyka
Copy link
Collaborator

tshyka commented Dec 6, 2023

Thanks for sharing these docs. Can you provide access to the CIVIC Box folder?

@youngmorse
Copy link

Hi Tom, I don't think I can't share the Box links because you are outside of GMRI but I'll send it to you. It's a cleaned up version of our WL product requirements from Google Docs.

@Adelle-Pitsas
Copy link
Contributor Author

There has been discussion about how and where different selectors are located and displayed. There have been a few iterations of this and screenshots can be found in #2803 and in PR #2811. In addition to the layout changes in these screenshots, the datum selection was moved from a dropdown to a radio button group. There was also discussion of the datum selection being a button group.
Examples of each selector style:
Dropdown:
Screenshot 2024-04-10 at 10 36 43 AM
Radio group:
Screenshot 2024-04-10 at 10 37 10 AM
Button group:
Screenshot 2024-04-10 at 10 37 53 AM

@youngmorse
Copy link

youngmorse commented Apr 12, 2024

I've been finding a few bugs while adding sensors. I'm adding them as comments w/detail then they can go up to the task list or promoted to new issues if needed.

  • The y-axis range is really big, it's more noticeable on the sensors with the smaller ranges. It does appear to be scaling dynamically but the range is too big.
Y-axis_range Y-axis_range2

@youngmorse
Copy link

youngmorse commented Apr 12, 2024

  • Unit system selection reverts back to English from Metric when you change stations or change time range. Works okay with Datum selection change (hard to show in a screen shot but easy to replicate!)
Screenshot 2024-04-12 at 4 20 53 PM Screenshot 2024-04-12 at 4 21 02 PM

@youngmorse
Copy link

youngmorse commented Apr 12, 2024

A couple of timeframe date select bugs (Firefox)

  • If you change the time range it retains the setting if you change platforms on that page. The URL stays the same as the selected range. Refreshing the browser doesn't reset to the default range, you have to click the 'Water Level' link in the menu and select a station to reset the range. (My first movie was too big to upload but shows the behavior a little more clearly.)
Screen.Recording.2024-04-12.at.4.51.48.PM.mov
  • If you use the calendar option the dates change fine. If you try to type a new date the fields disappear!
Screen.Recording.2024-04-12.at.4.50.38.PM.mov

@youngmorse
Copy link

youngmorse commented Apr 12, 2024

These two are related to the marker status if flood levels are detected:

  • On the Water Level landing page, the flood marker color doesn't change for CASM1 to show Moderate but the tooltip shows that it's moderate. It did change to show markers with Action level for stations further south (CT)
Marker_not_showing_flood

action_flood_marker

  • This shows the CASM1 station detail page does change color for moderate flooding. (note: I temporarily lowered the flood benchmarks at this station to show a moderate flood level)
Moderate_flood_marker

@youngmorse
Copy link

youngmorse commented Apr 12, 2024

These next few are enhancements not bugs...

New features/behaviors:

  • Add vertical line to show current time on plot

Changes to current features/behavior (open to discussion)

  • Default time is GMT - do we want to convert to EST?
timestamp_GMT
  • For stations with not a lot of difference in benchmarks, it's hard to see the difference in the two levels. the https://water.noaa.gov has this problem too, so it may be a tough one to solve.
Benchmarks_too_close
  • For stations that have a lot of additional data do we want to limit what we show in the station info? Noticed this on a station that had 6-7 variables.
Screenshot 2024-04-12 at 5 13 43 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants