Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Units should stay the same when changing stations #2858

Closed
1 task
Adelle-Pitsas opened this issue Apr 18, 2024 · 2 comments · Fixed by #2899
Closed
1 task

Units should stay the same when changing stations #2858

Adelle-Pitsas opened this issue Apr 18, 2024 · 2 comments · Fixed by #2899
Assignees

Comments

@Adelle-Pitsas
Copy link
Contributor

  • Unit system selection reverts back to English from Metric when you change stations or change time range. Works okay with Datum selection change (hard to show in a screen shot but easy to replicate!)
Screenshot 2024-04-12 at 4 20 53 PM Screenshot 2024-04-12 at 4 21 02 PM

Originally posted by @youngmorse in #2701 (comment)

@abkfenris
Copy link
Member

We might want to think about using URL params and/or cookies for current unit and datum selections and to persist defaults for users.

@Adelle-Pitsas
Copy link
Contributor Author

Updating here as I've been working on the unit selections and default state on WL pages. PR #2899 puts unit selection in session storage to persist over url changes and refreshes. It will revert to default if a user opens a new tab (a new session).

Datum selection is currently included in url params and persists on sensor/url change and refreshes. It defaults to MLLW when a user first selects a sensor from the base /water-level url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants