Funding page suggestions #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansallinen
commented
Dec 19, 2024
| @@ -151,78 +153,77 @@ | |||
| } | |||
| </script> | |||
|
|
|||
| <div class="max-w-5xl space-y-6"> | |||
| <h2 class="h4">{m.token_purchase_providers()}</h2> | |||
| <Stack class="gap-12"> | |||
There was a problem hiding this comment.
add a bigger gap between sections
Deploying 2nicove with
|
| Latest commit: |
e9db6cd
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4501cd6e.unicove2.pages.dev |
| Branch Preview URL: | https://funding-page-dean.unicove2.pages.dev |
deansallinen
commented
Dec 19, 2024
| <div> | ||
| <div class="mb-4 flex items-center justify-center"> | ||
| <img src={service.logo} alt={service.id} class="h-24 w-3/5 object-contain" /> | ||
| <MultiCard tag="ul"> |
There was a problem hiding this comment.
Multicard here takes card of the switch between mobile and desktop
deansallinen
commented
Dec 19, 2024
Comment on lines
+178
to
+182
| <DLRow title={m.details()}> | ||
| {#each service.details as detail} | ||
| <DD class="text-white">{detail}</DD> | ||
| {/each} | ||
| </DLRow> |
There was a problem hiding this comment.
dl can take multiple dd elements per dt so I've done that here. Slight deviation from the design but it matches the rest of the card.
deansallinen
commented
Dec 19, 2024
| </Grid> | ||
| <p>{m.where_eos_can_be_purchased()}</p> | ||
|
|
||
| <Grid tag="ul" itemWidth="10rem" class=""> |
There was a problem hiding this comment.
Setting the itemWidth here rather than explicitly setting grid cols lets it go down to single column on the smallest screens. I think it's a better experience, but let me know.
There was a problem hiding this comment.
I thought that having 2 cards per row looked fine on mobile, but having one item per row also works.
dafuga
approved these changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.