Funding page #318
Merged
Funding page #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Deploying 2nicove with
|
| Latest commit: |
9d3fa4f
|
| Status: | ⚡️ Build in progress... |
static/binance.webp
Outdated
There was a problem hiding this comment.
Goes for all the images:
We should put these in the src/lib/assets directory, then import them in the <script> tag of the component. That way Vite can preprocess them. Also, in my branch for the homepage I'm adding the @svelte/enhanced-img plugin which will take it one step further and generate a srcset for each image when using <enhanced:img> tag.
We can upgrade to the enhanced image tag later, but for now I'd say let's put the images in a folder in assets
There was a problem hiding this comment.
If you rebase on dev you should now be able to use <enhanced:img> for these assets
Co-authored-by: Dean Sallinen <[email protected]>
Co-authored-by: Dean Sallinen <[email protected]>
Co-authored-by: Dean Sallinen <[email protected]>
Co-authored-by: Dean Sallinen <[email protected]>
Co-authored-by: Dean Sallinen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.