forked from bazel-contrib/rules_nodejs
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore: update NodeJS to LTS 12.13.0 and yarn to 1.19.1 version (bazel…
…-contrib#1313) * fix(jasmine): fix dynamic import test for extensionless imports nearest parent package.json should contain a top-level field "type": https://nodejs.org/docs/latest-v12.x/api/esm.html#esm_enabling * fix(examples): loosen node version requirement to include 12 LTS * fix(labs): bump dependency versions jsdoc peer dependency `requizzle` is failing due to this: hegemonic/requizzle#6 * fix(labs): unpin protobufjs dependency version from commit sha to latest * fix(labs): match @bazel/labs protobufjs dependencies with protobuf.js 6.8.8 deps in other case protobuf.js will try to npm install mismatched dependency versions programmatically and fail due to read-only sandbox fs: https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/cli/util.js#L129 https://github.com/protobufjs/protobuf.js/blob/69623a91c1e4a99d5210b5295a9e5b39d9517554/package.json * fix(labs): freeze protobufjs version in place other dependencies here should have the same major version as in protobufjs package.json
- Loading branch information
Showing
6 changed files
with
257 additions
and
213 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
describe('args', () => { | ||
it('should pass through templated_args', async () => { | ||
// without --node_options=--experimental-modules this will fail | ||
const dynamicImport = await import('./dynamic_import'); | ||
const dynamicImport = await import('./dynamic_import.js'); | ||
dynamicImport.default.hello(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.