-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(blooms): Disable metas cache on bloom gateway #12959
Conversation
Signed-off-by: Christian Haudum <[email protected]>
@@ -727,7 +727,7 @@ func (t *Loki) initBloomStore() (services.Service, error) { | |||
bsCfg := t.Cfg.StorageConfig.BloomShipperConfig | |||
|
|||
var metasCache cache.Cache | |||
if cache.IsCacheConfigured(bsCfg.MetasCache) { | |||
if t.Cfg.isTarget(IndexGateway) && cache.IsCacheConfigured(bsCfg.MetasCache) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is the actual fix to enable the metas cache only on index gateways.
Hi @chaudum, our loki is running in ssd mode, where index gateway is on backend node, we found that bloom shipper metas cache is not working, probably because your above MR allows only metas cache on index-gateway. therefore, I prepared this MR: #15275, to allow metas cache on backend node, can you please review it? thanks. |
What this PR does / why we need it:
The bloom gateway does not fetch any metas any more since the index gateway resolves them.
Renamed
isModuleEnabled()
toisTarget()
, because the function name is confusing.Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR