Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add missing Helm helper loki.hpa.apiVersion (#12716) #12721

Closed
wants to merge 16 commits into from
Closed

fix: Add missing Helm helper loki.hpa.apiVersion (#12716) #12721

wants to merge 16 commits into from

Conversation

mattgialelis
Copy link
Contributor

@mattgialelis mattgialelis commented Apr 22, 2024 •
edited
Loading

What this PR does / why we need it:

Currently the 6.3.3 and 6.2.2. helm charts when trying to enable the Horizontal Pod Autoscaler for the Distributed deployment type fails due to the missing loki.hpa.apiVersion which is required for the the Helm chart to template/install making it un-useable for large scale deployments with the need for autoscaling

Error that is fixed by this PR

Error: template: loki/templates/query-frontend/hpa.yaml:3:19: executing "loki/templates/query-frontend/hpa.yaml" at <include "loki.hpa.apiVersion" .>: error calling include: template: no template "loki.hpa.apiVersion" associated with template "gotpl"

Which issue(s) this PR fixes:
Fixes #12716

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@mattgialelis mattgialelis requested a review from a team as a code owner April 22, 2024 07:48
@CLAassistant
Copy link

CLAassistant commented Apr 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@JStickler JStickler changed the title Fix: Add missing Helm helper loki.hpa.apiVersion (#12716) fix: Add missing Helm helper loki.hpa.apiVersion (#12716) Apr 22, 2024
@JStickler
Copy link
Contributor

@mattgialelis Could you also please update production/helm/loki/README.md. as mentioned in the PR checklist and update the documentation by running helm-docs and committing the changes.

@mattgialelis
Copy link
Contributor Author

@JStickler Both requested steps have been done

snrnats and others added 15 commits April 23, 2024 15:00
@snrnats @mattgialelis
fix: Add missing OTLP endpoint to nginx config (grafana#12709)
1a72a5e
@cstyan @mattgialelis
ci: update drone image version to 0.33.2 (grafana#12730)
2c1077a 
Signed-off-by: Callum Styan <[email protected]>
@seizethedave @mattgialelis
docs: Fix mangled admonition block in alerting/recording rule docs (g…
dc285b4 
…rafana#12733)
@paul1r @JStickler @mattgialelis
docs: Add Azure example configuration snippets (grafana#12725)
e2d2725 
Co-authored-by: J Stickler <[email protected]>
@cstyan @mattgialelis
fix: update to build image 0.33.2, fixes bug with promtail windows DN…
8920b98 
…S resolution (grafana#12732)

Signed-off-by: Callum Styan <[email protected]>
@MasslessParticle @mattgialelis
fix(docs): broken link in getting started readme (grafana#12736)
bf95ad4
@joshuapare @cstyan @mattgialelis
fix(promtail): Fix UDP receiver on syslog transport (grafana#10708)
2f2182a 
Co-authored-by: Callum Styan <[email protected]>
@chaudum @mattgialelis
perf(blooms): Resolve bloom blocks on index gateway and shard by bloc…
27ae3a3 
…k address (grafana#12720)

This pull request changes how data is sharded across bloom gateways.

Currently, chunks are grouped by series and shared by the fingerprint of the series across the available bloom gateways using jumphash algorithm. This however, leads to over-querying bloom blocks, because bloom blocks have consecutive fingerprint ranges, whereas sharding keys are evenly distributed across keyspace.

This PR changes the sharding in the way that bloom blocks for series are already resolved on the index gateways and that their address is used for sharding data. This has the advantage that the grouped series can be mapped to the correct bloom blocks on the client side. Sending the block ref along with the grouped series to the bloom gateway allows for efficient querying of the data because each bloom gateway therefore owns exactly 1/nth of the blocks.

---

Signed-off-by: Christian Haudum <[email protected]>
@dependabot @periklis @mattgialelis
chore(deps): bump golang.org/x/net from 0.22.0 to 0.23.0 (grafana#12699)
e2a6df2 
Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Periklis Tsirakidis <[email protected]>
@dependabot @periklis @mattgialelis
chore(deps): bump golang.org/x/net from 0.21.0 to 0.23.0 in /operator (…
eed6e95 
…grafana#12698)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Periklis Tsirakidis <[email protected]>
@dependabot @periklis @mattgialelis
chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 in /tools/la…
d1915e9 
…mbda-promtail (grafana#12696)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Periklis Tsirakidis <[email protected]>
@dependabot @periklis @mattgialelis
chore(deps): bump golang.org/x/net from 0.17.0 to 0.23.0 in /pkg/push (…
5425886 
…grafana#12694)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Periklis Tsirakidis <[email protected]>
@DylanGuedes @mattgialelis
fix: helm: Set compactor addr for distributed mode. (grafana#12748)
9e4f29d
@paul1r @mattgialelis
test: Data race updates for memchunk tests (grafana#12752)
6d6e0b5
@mattgialelis
fix: Add missing Helm helper loki.hpa.apiVersion (grafana#12716)
d2ee60b
@github-actions github-actions bot added sig/operator type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories labels Apr 23, 2024
@mattgialelis mattgialelis deleted the FixHPAHelmHeplers branch April 23, 2024 14:04
@JStickler
Copy link
Contributor

Replaced by #12755

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sweightman sweightman sweightman approved these changes

@andrzej-PM andrzej-PM andrzej-PM approved these changes

@periklis periklis Awaiting requested review from periklis periklis is a code owner

@xperimental xperimental Awaiting requested review from xperimental xperimental is a code owner

Assignees
No one assigned
Labels
area/helm sig/operator size/XXL type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Executing "loki/templates/query-frontend/hpa.yaml" at <include "loki.hpa.apiVersion" .>: error calling includ