Add TODO to Frame.SetContent #4538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inancgumus
requested review from
oleiade and
codebien
and removed request for
a team
inancgumus
requested review from
olegbespalov
and removed request for
oleiade
codebien
previously approved these changes
Feb 11, 2025
| @@ -1473,6 +1473,8 @@ func (f *Frame) selectOption(selector string, values []any, opts *FrameSelectOpt | |||
| func (f *Frame) SetContent(html string, _ *FrameSetContentOptions) error { | |||
| f.log.Debugf("Frame:SetContent", "fid:%s furl:%q", f.ID(), f.URL()) | |||
|
|
|||
| // TODO(@inancgumus): Respect the FrameSetContentOptions before executing the action. | |||
There was a problem hiding this comment.
Out of curiosity, would it be enough by wrapping the context with the timeout or do we need something else? It would be good to have a suggestion regarding how to fix it so whoever will look into it then they might have a better starting point.
There was a problem hiding this comment.
Yes, a suggestion would be good. But it's complicated to explain since the option not only involves a timeout, it also involves waiting for a "lifecycle" event. I've added a small suggestion: 41af72a
codebien
approved these changes
Feb 12, 2025
olegbespalov
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per #4533 (comment).