Refactor lib/consts/consts.go #4537
Open
+74
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codebien
force-pushed
the
refactor-lib-consts
branch
from
df82813 to
7e172af
Compare
codebien
requested review from
oleiade,
joanlopez,
a team and
inancgumus
and removed request for
a team and
oleiade
| @@ -0,0 +1,6 @@ | |||
| // Package version handles k6 versioning | |||
| package version | |||
There was a problem hiding this comment.
I'm curious if we really need the package for that? 🤔
How about moving this to the root (main package) and just access it as go.k6.io/k6.Version ?
| // | ||
| // Deprecated: alias to support the legacy versioning API. Use the new version package, | ||
| // it will be removed as soon as the external services stop to depend on it. | ||
| const Version = version.SemVer |
There was a problem hiding this comment.
Do you think that migration to the new const is hard enough? I mean, why not clean the package and just announce the breaking change?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
It creates a dedicated package for version management. It moves the Semantic Versioning constant string to the new pkg, and it aliases the old.
Why?
It reduces the public surface of k6 API.